v17.4.0 release proposal by targos · Pull Request #41557 · nodejs/node · GitHub

Notable Changes

[ef6f98c2e3] - (SEMVER-MINOR) child_process: add support for URL to cp.fork (Antoine du Hamel) #41225
[d62fe315c2] - (SEMVER-MINOR) crypto: alias webcrypto.subtle and webcrypto.getRandomValues on crypto (James M Snell) #41266
[fcb37e9ce5] - doc: add Mesteery to collaborators (Mestery) #41543
[4079fc42b7] - (SEMVER-MINOR) events: graduate capturerejections to supported (James M Snell) #41267
[fe21607901] - (SEMVER-MINOR) events: add EventEmitterAsyncResource to core (James M Snell) #41246
[6d8eb6ace6] - (SEMVER-MINOR) loader: return package format from defaultResolve if known (Gabriel Bota) #40980
[27c619140a] - (SEMVER-MINOR) perf_hooks: multiple fixes for Histogram (James M Snell) #41153
[09c25bb224] - (SEMVER-MINOR) stream: add filter method to readable (Benjamin Gruenbaum, Robert Nagy) #41354
[1150963217] - (SEMVER-MINOR) stream: add isReadable helper (Robert Nagy) #41199
[9f5a873965] - (SEMVER-MINOR) stream: add map method to Readable (Benjamin Gruenbaum, Robert Nagy) #40815

Commits

[314102b14d] - async_hooks: add missing initialization (Michael Dawson) #41288
[56345a3f63] - async_hooks: fix AsyncLocalStorage in unhandledRejection cases (Bradley Farias) #41202
[fa84353952] - benchmark: simplify http benchmarker regular expression (Rich Trott) #38206
[88d760c559] - benchmark: fix benchmark/run.js handling of --set (Rich Trott) #41334
[dcf1ea0a3f] - benchmark,test: use Object.hasOwn() where applicable (Rich Trott) #41229
[e8538c3751] - build: fix node build failures in WSL Ubuntu (MrJithil) #41476
[3d88ea195e] - build: fix workflow access to git history (Rich Trott) #41472
[b0f0ad1004] - build: start build on z/OS (alexcfyung) #41273
[80a3766ac7] - build: use list for mutable retval rather than tuple (Rich Trott) #41372
[afe1e00509] - build: remove Python 2 workaround (Rich Trott) #41357
[011c5f6498] - build: improve readability of texts in workflows (Mestery) #40988
[2233f31069] - build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable (David Sanders) #41235
[d9465ae614] - child_process: queue pending messages (Erick Wendel) #41221
[ed41fd110d] - child_process: revise argument processing (Rich Trott) #41280
[ef6f98c2e3] - (SEMVER-MINOR) child_process: add support for URL to cp.fork (Antoine du Hamel) #41225
[d62fe315c2] - (SEMVER-MINOR) crypto: alias webcrypto.subtle and webcrypto.getRandomValues on crypto (James M Snell) #41266
[8ea56a9606] - crypto: fix error capture when loading engine (Tobias Nießen) #41187
[f5b8aee1a1] - deps: upgrade npm to 8.3.1 (npm-robot) #41503
[af3acecd7e] - deps: V8: cherry-pick 3b6b21f595f6 (Michaël Zasso) #41457
[02ca5d7c7c] - deps: upgrade to libuv 1.43.0 (Colin Ihrig) #41398
[48e4780fd7] - doc: remove statement about client private keys (Tobias Nießen) #41505
[ba7160e815] - doc: fix typo in onboarding.md (Antoine du Hamel) #41544
[fcb37e9ce5] - doc: add Mesteery to collaborators (Mestery) #41543
[abbfed8789] - doc: add missing word in readable.read() text (Rich Trott) #41524
[712dfdc11f] - doc: add missing YAML tag in esm.md (Antoine du Hamel) #41516
[f443a4e8fa] - doc: expand fs.access() mode parameter docs (Colin Ihrig) #41484
[5c0c459976] - doc: correct checkHost behavior with wildcards etc (Tobias Nießen) #41468
[c632241440] - doc: remove extraneous colon in legacy subject (Tobias Nießen) #41477
[b7b0631b10] - doc: remove SameValue comparison reference (Rich Trott) #41460
[524103d6bf] - doc: update mailmap entries for mhdawson (Michael Dawson) #41437
[62aa190c01] - doc: add guidance on order vulns are listed in (Michael Dawson) #41429
[d721a758b2] - doc: update output in inspector examples (David Sanders) #41390
[60025bde16] - doc: add note regarding unfinished TLA (Antoine du Hamel) #41434
[10bdb5969e] - doc: add reference for === operator in assert.md (Rich Trott) #41442
[edc6a7af42] - doc: clarify uncaughtException origin for ESM (Antoine du Hamel) #41339
[4a369d03b4] - doc: revise HTTPRequestOptions text (Rich Trott) #41407
[f43bfe2e16] - doc: add reference for == and != operators (Rich Trott) #41413
[d3111bf0cc] - doc: add @RaisinTen to the TSC (Michael Dawson) #41419
[e6bed4e972] - doc: update Abstract Equality Comparison text in assert.md (Rich Trott) #41375
[19db19bb80] - doc: fix example commands for REPLACEME updates (Richard Lau) #41269
[16c0bea91d] - doc: document that require.main may be undefined (Antoine du Hamel) #41384
[014d4836ec] - doc: clarify entry point behavior when using loader hooks (Antoine du Hamel) #41304
[6460b1b32d] - doc: clarify require behavior with non .js extensions (Antoine du Hamel) #41345
[0d18a8c232] - doc: revise frozen-intrinsics text (Rich Trott) #41342
[c267bb2192] - doc: fix example description for worker_threads (Dmitry Petrov) #41341
[ffe17a84f2] - doc: make pull-request guide default branch agnostic (Antoine du Hamel) #41299
[5cfc547997] - doc: fix sync comment in observer snippet (Eric Jacobson) #41262
[3a80104b29] - doc: remove section about amending commits in PR guide (Thiago Santos) #41287
[23f97ec04e] - doc: remove legacy in-page links in v8.md (Rich Trott) #41291
[e819685cec] - doc: include stack trace difference in ES modules (Marcos Bérgamo) #41157
[dac8407944] - doc: fix example in node-api docs (Michael Dawson) #41264
[29563abd85] - doc: add usage recommendation for writable._destroy (Rafael Gonzaga) #41040
[e27e8272f7] - doc: make function signature comply with JSDoc comment (Rich Trott) #41242
[d83a02994c] - doc: align maxHeaderSize default with current value (Gil Pedersen) #41183
[730e25d7dd] - doc: add unhandledRejection to strict mode (Colin Ihrig) #41194
[74742c3618] - doc: adding estimated execution time (mawaregetsuka) #41142
[34ef5a7d4d] - doc: fix syntax error in nested conditions example (Mateusz Burzyński) #41205
[c9a4603913] - esm: make process.exit() default to exit code 0 (Gang Chen) #41388
[8a94ca7a69] - esm: refactor esm tests out of test/message (Geoffrey Booth) #41352
[5ebe086ea6] - esm: reconcile JSDoc vs. actual parameter name (Rich Trott) #41238
[9fe304b8e8] - events: clarify JSDoc entries (Rich Trott) #41311
[4079fc42b7] - (SEMVER-MINOR) events: graduate capturerejections to supported (James M Snell) #41267
[e3a0a9cb3a] - events: add jsdoc details for Event and EventTarget (James M Snell) #41274
[fe21607901] - (SEMVER-MINOR) events: add EventEmitterAsyncResource to core (James M Snell) #41246
[d4a6f2caf1] - fs: use async directory processing in cp() (Colin Ihrig) #41351
[0951bd94db] - fs: correct param names in JSDoc comments (Rich Trott) #41237
[1d75436a1c] - http: remove duplicate code (Shaw) #39239
[0aacd4926d] - http2: handle existing socket data when creating HTTP/2 server sessions (Tim Perry) #41185
[24fbbf2747] - lib: remove spurious JSDoc entry (Rich Trott) #41240
[e457ec05d6] - lib: fix checking syntax of esm module (Qingyu Deng) #41198
[f176124e8b] - lib,tools: remove empty lines between JSDoc tags (Rich Trott) #41147
[68fd2ac999] - loader: fix package resolution for edge case (Gabriel Bota) #41218
[6d8eb6ace6] - (SEMVER-MINOR) loader: return package format from defaultResolve if known (Gabriel Bota) #40980
[a6146c7e27] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #41456
[07353e9b8b] - meta: update AUTHORS (Node.js GitHub Bot) #41475
[e1ff4521d7] - meta: correct my name in AUTHORS (Jacob Smith) #41444
[da1d5d6563] - meta: update AUTHORS (Node.js GitHub Bot) #41449
[0f9afa58d5] - meta: add required fields in issue templates (Rich Trott) #41378
[da04408075] - meta: update AUTHORS (Node.js GitHub Bot) #41374
[1f6c4e819b] - meta: replace API docs issue template with form (Rich Trott) #41348
[253c3e5488] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #41336
[3e188cacc2] - meta: replace feature request template with form (Rich Trott) #41317
[e339220511] - meta: update AUTHORS (Node.js GitHub Bot) #41322
[d0d595f8f2] - meta: update node-api team name (Richard Lau) #41268
[a53fa2010b] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #41248
[edefb41ec1] - meta: update AUTHORS (Node.js GitHub Bot) #41234
[6da7909797] - meta: remove community-committee from CODEOWNERS (Rich Trott) #41169
[5fe011a24d] - node-api: add missing initialization of last error (Michael Dawson) #41290
[27c619140a] - (SEMVER-MINOR) perf_hooks: multiple fixes for Histogram (James M Snell) #41153
[e60187d8ab] - policy: add missing JSDoc @PARAM entry (Rich Trott) #41239
[ec9071f55d] - src: use std::optional for Worker thread id (Anna Henningsen) #41453
[6aec92f959] - src: gracefully handle errors in GetX509NameObject (Tobias Nießen) #41490
[7ac126b75c] - src: fix out-of-bounds check of serialization indices (JoostK) #41452
[93b3664b9a] - src: do IWYU for some STL includes (David Sanders) #41236
[337ebfcd53] - src: split out async stack corruption detection from inline fn (Anna Henningsen) #41331
[250e197a62] - src: store native async execution resources as v8::Local (Anna Henningsen) #41331
[6187e81a8e] - src: guard slightly costly check in MakeCallback more strongly (Anna Henningsen) #41331
[51d86fe6a0] - stream: remove always-false condition check (Rich Trott) #41488
[b08138f367] - stream: fix error-path function call (Rich Trott) #41433
[d79f8c2987] - stream: remove unused function argument (Rich Trott) #41403
[09c25bb224] - (SEMVER-MINOR) stream: add filter method to readable (Benjamin Gruenbaum) #41354
[1150963217] - (SEMVER-MINOR) stream: add isReadable helper (Robert Nagy) #41199
[9f5a873965] - (SEMVER-MINOR) stream: add map method to Readable (Benjamin Gruenbaum) #40815
[3dc65646c8] - stream: fix enqueue race condition on esm modules (Rafael Gonzaga) #40901
[09f2fd36a4] - test: improve test coverage of dns/promises (Yoshiki Kurihara) #41425
[106ef0cef4] - test: remove broken wiki link from test/common doc (Yoshiki Kurihara) #41426
[9d8d7c63cb] - test: do not OR F_OK in fs.access() test (Colin Ihrig) #41484
[3e2154deda] - test: mark test-performance-eventloopdelay flaky (Michael Dawson) #41409
[e808ee68d0] - test: mark test-repl-sigint-nested-eval as flaky (Michael Dawson) #41302
[f97f6c585d] - test: use spawnSync() full name in test-stdio-pipe-stderr (Rich Trott) #41332
[75c565bf18] - test: improve expectWarning error message (Rich Trott) #41326
[c136d597f0] - test: use spawnSync() full name (Rich Trott) #41327
[b2a87f770d] - test: add comments explaining _setSimultaneousAccepts deprecation tests (Yoshiki Kurihara) #41307
[fac0871102] - test: mark test-worker-take-heapsnapshot flaky (Michael Dawson) #41253
[90617b9303] - test: mark wpt/test-user-timing test flaky (Michael Dawson) #41203
[8f08328a01] - test: correct param name in JSDoc comment (Rich Trott) #41241
[367ab2a55e] - test: mark test-crypto-keygen slow on windows (Michael Dawson) #41207
[f067876338] - test: improve test coverage of dns/promises (Yoshiki Kurihara) #41133
[2e92f6f5d9] - timers: use ref counts to count timers (Darshan Sen) #41231
[3c8b25bec8] - tls: use optional chaining to simplify checks (Antoine du Hamel) #41337
[a11ff31bca] - tls: permit null as a pfx value (CallMeLaNN) #41170
[5129b7c802] - tools: fix small not-quite-a-bug in find-inactive-tsc.mjs (Rich Trott) #41469
[258ee4ba64] - tools: enable ESLint recommended configuration (Rich Trott) #41463
[090a674a81] - tools: enable ESLint no-constant-condition rule (Rich Trott) #41463
[1f4369a106] - tools: enable ESLint require-yield rule (Rich Trott) #41463
[8090ce7a6c] - tools: enable ESLint no-sparse-arrays rule (Rich Trott) #41463
[afa4f37faf] - tools: enable ESLint no-loss-of-precision rule (Rich Trott) #41463
[ec337b2019] - tools: replace for loop with map() (Rich Trott) #41451
[c91ac205a5] - tools: use GITHUB_ACTIONS env var in inactivity scripts (Rich Trott) #41422
[4a57d476a8] - tools: replace while+exec() with matchAll() (Rich Trott) #41406
[583f8d969a] - tools: fix argv bug in find-inactive-tsc.mjs (Rich Trott) #41394
[dcada80f30] - tools: remove conditional assignment in custom ESLint rule (Rich Trott) #41325
[e15e1cb030] - tools: update lint-md-dependencies to @rollup/plugin-node-resolve@13.1.2 (Node.js GitHub Bot) #41369
[07683021b7] - tools: update doc to rehype-raw@6.1.1 (Node.js GitHub Bot) #41367
[bd8b95a5e8] - tools: remove last of error-masking in commit-queue.sh (Rich Trott) #41356
[9284d24df6] - tools: update eslint to 8.6.0 (Node.js GitHub Bot) #41368
[5fc886f68e] - tools: do not mask errors on multiple commit retrieval (Rich Trott) #41340
[0ca7cda962] - tools: enable jsdoc/check-param-names lint rule (Rich Trott) #41311
[75ff8e6505] - tools: improve section tag additions in HTML doc generator (Rich Trott) #41318
[9c4124706e] - tools: simplify commit-queue.sh merge command (Rich Trott) #41314
[137c814848] - tools: update lint-md-dependencies to rollup@2.62.0 (Node.js GitHub Bot) #41315
[58da5d9b43] - tools: use Object.hasOwn() in alljson.mjs (Rich Trott) #41306
[c12cbf2020] - tools: avoid generating duplicate id attributes (Rich Trott) #41291
[80a114d1b7] - tools: be intentional about masking possible error in start-ci.sh (Rich Trott) #41284
[198528426d] - tools: use {N} for spaces in regex (Rich Trott) #41295
[46b364a684] - tools: consolidate update-authors.js logic (Rich Trott) #41255
[c546cef4bc] - tools: update doc dependency mdast-util-gfm-table to 1.0.2 (Rich Trott) #41260
[60c059e4bc] - tools: make license-builder.sh comply with shellcheck 0.8.0 (Rich Trott) #41258
[62e28f19f7] - tools: use arrow function for callback in lint-sh.js (Rich Trott) #41256
[e2df381da9] - tools: add double-quotes to make-v8.sh (Rich Trott) #41257
[dae2e5fffa] - tools: enable prefer-object-has-own lint rule (Rich Trott) #41245
[aa7d14768d] - tools: update eslint to 8.5.0 (Node.js GitHub Bot) #41228
[0c14e7e7c8] - tools: enable jsdoc/tag-lines ESLint rule (Rich Trott) #41147
[c486da1715] - tools: update lint-md-dependencies to @rollup/plugin-node-resolve@13.1.1 (Node.js GitHub Bot) #41227
[82f492bbb0] - tools: fix CQ and auto-start-ci jobs (Antoine du Hamel) #41230
[c44185ca37] - tools: fix GitHub Actions status when CQ is empty (Antoine du Hamel) #41193
[800640adf9] - tools,benchmark,lib,test: enable no-case-declarations lint rule (Rich Trott) #41385
[4518fdda24] - tools,lib,test: enable ESLint no-regex-spaces rule (Rich Trott) #41463
[c8e8fc0ecb] - typings: add types for symbol and accessor properties on primordials (ExE Boss) #40992
[d733b56101] - typings: add JSDoc for string_decoder (Qingyu Deng) #38229
[01ad8debd3] - url,lib: pass urlsearchparams-constructor.any.js (Khaidi Chu) #41197
[5ed8a1c017] - util: do not reduce to a single line if not appropriate using inspect (Ruben Bridgewater) #41083
[ab5e94c832] - util: display a present-but-undefined error cause (Jordan Harband) #41247

This is a proposed modification of defaultResolve to return the package format in case it has been found during package resolution. The format will be returned as described in the documentation: https://nodejs.org/api/esm.html#resolvespecifier-context-defaultresolve There is one new unit test as well: test/es-module/test-esm-resolve-type.js PR-URL: #40980 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Files previously managed by TSC + CommComm are now managed by TSC. PR-URL: #41169 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: #41187 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: #41205 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com>

PR-URL: #41142 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Stewart X Addison <sxa@redhat.com>

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #41230 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #41227 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

This is in preparation for enabling a recommended JSDoc lint rule. PR-URL: #41147 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This rule is part of the JSDoc ESLint plugin's recommneded rule set. It prohibits blank lines between JSDoc tags. PR-URL: #41147 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #41228 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

`lib/internal/process/promises.js` contains the following comment about --unhandled-rejections=strict. This commit updates the docs to reflect this: // --unhandled-rejections=strict: // Emit 'uncaughtException'. If it's not handled, print // the error to stderr and exit the process. // Otherwise, emit 'unhandledRejection'. If // 'unhandledRejection' is not // handled, emit 'UnhandledPromiseRejectionWarning'. Fixes: #41184 PR-URL: #41194 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #41234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #40988 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

* The createHistogram(options) options weren't actually implemented * Add a new count property that tracks the number of samples * Adds BigInt options for relevant properties * Adds add(other) method for RecordableHistogram * Cleans up and expands tests * Eliminates unnecessary ELDHistogram native class * Improve/Simplify histogram transfer impl Signed-off-by: James M Snell <jasnell@gmail.com> perf_hooks: simplify Histogram constructor options Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #41153 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

PR-URL: #41225 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #41133 Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>

PR-URL: #41183 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #41189 PR-URL: #41198 Refs: #37468 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn PR-URL: #41229 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

PR-URL: #41242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

stream: use nextTick on close PR-URL: #40901 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Refs: #41206 This test seems to be failing regularly on windows with a timeout. Mark it slow to reduce CI noise until it gets investigated. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41207 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #41202 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

PR-URL: #41239 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #41238 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #41237 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #41245 Refs: https://eslint.org/docs/rules/prefer-object-has-own Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #41241 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #41240 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

CI: https://ci.nodejs.org/job/node-test-pull-request/41945/

See https://ci.nodejs.org/job/citgm-smoker/2830/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/tape_v5_4_1/ for example:

 > eclint check $(git ls-files | xargs find 2> /dev/null | grep -vE 'node_modules|\.git')
 fatal: not a git repository (or any of the parent directories): .git
 node:events:498
       throw er; // Unhandled 'error' event
       ^
 Error: File not found with singular glob: /home/iojs/tmp/citgm_tmp/cda532cd-f3b0-4fe4-9c0f-31ba9fed34d3/tape/test/has (if this was purposeful, use `allowEmpty` option)
     at Glob.<anonymous> (/home/iojs/tmp/citgm_tmp/cda532cd-f3b0-4fe4-9c0f-31ba9fed34d3/tape/node_modules/glob-stream/readable.js:84:17)

ah right, because of the git ls-files. I’ll modify that command so it doesn’t fail when it’s not a git repo.

@targos Any chance we can get in this release the commits that landed today on master?

unless there's something critical, I won't have more time to spend on this.

per nodejs/node#41557 (comment)

tape should be fixed in tape-testing/tape@b9959f8, assuming you're using the latest commit and not the latest release.

CI: https://ci.nodejs.org/job/node-test-pull-request/41979/

Release build: https://ci-release.nodejs.org/job/iojs+release/8215/

Release is blocked on nodejs/build#2850

lgtm

Npm's package.json now contains two fields named "version". Grep for the top-level one. Fixes: nodejs/build#2850 PR-URL: #41575 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Notable changes: child_process: * (SEMVER-MINOR) add support for URL to `cp.fork` (Antoine du Hamel) #41225 crypto: * (SEMVER-MINOR) alias webcrypto.subtle and webcrypto.getRandomValues on crypto (James M Snell) #41266 doc: * add Mesteery to collaborators (Mestery) #41543 events: * (SEMVER-MINOR) graduate capturerejections to supported (James M Snell) #41267 * (SEMVER-MINOR) add EventEmitterAsyncResource to core (James M Snell) #41246 loader: * (SEMVER-MINOR) return package format from defaultResolve if known (Gabriel Bota) #40980 perf_hooks: * (SEMVER-MINOR) multiple fixes for Histogram (James M Snell) #41153 stream: * (SEMVER-MINOR) add filter method to readable (Benjamin Gruenbaum, Robert Nagy) #41354 * (SEMVER-MINOR) add isReadable helper (Robert Nagy) #41199 * (SEMVER-MINOR) add map method to Readable (Benjamin Gruenbaum, Robert Nagy) #40815 PR-URL: #41557

New release build: https://ci-release.nodejs.org/job/iojs+release/8216/

PR-URL: #41557

Notable changes: child_process: * (SEMVER-MINOR) add support for URL to `cp.fork` (Antoine du Hamel) #41225 crypto: * (SEMVER-MINOR) alias webcrypto.subtle and webcrypto.getRandomValues on crypto (James M Snell) #41266 doc: * add Mesteery to collaborators (Mestery) #41543 events: * (SEMVER-MINOR) graduate capturerejections to supported (James M Snell) #41267 * (SEMVER-MINOR) add EventEmitterAsyncResource to core (James M Snell) #41246 loader: * (SEMVER-MINOR) return package format from defaultResolve if known (Gabriel Bota) #40980 perf_hooks: * (SEMVER-MINOR) multiple fixes for Histogram (James M Snell) #41153 stream: * (SEMVER-MINOR) add filter method to readable (Benjamin Gruenbaum, Robert Nagy) #41354 * (SEMVER-MINOR) add isReadable helper (Robert Nagy) #41199 * (SEMVER-MINOR) add map method to Readable (Benjamin Gruenbaum, Robert Nagy) #40815 PR-URL: #41557

Refs: nodejs/node#41557

per nodejs/node#41557 (comment)

dygabo and others added 30 commits January 14, 2022 16:18

doc: adding estimated execution time

74742c3

PR-URL: #41142 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Stewart X Addison <sxa@redhat.com>

tools: fix GitHub Actions status when CQ is empty

c44185c

Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

tools: fix CQ and auto-start-ci jobs

82f492b

PR-URL: #41230 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

tools: update lint-md-dependencies to @rollup/plugin-node-resolve@13.1.1

c486da1

PR-URL: #41227 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

lib,tools: remove empty lines between JSDoc tags

f176124

This is in preparation for enabling a recommended JSDoc lint rule. PR-URL: #41147 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

tools: enable jsdoc/tag-lines ESLint rule

0c14e7e

This rule is part of the JSDoc ESLint plugin's recommneded rule set. It prohibits blank lines between JSDoc tags. PR-URL: #41147 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

meta: update AUTHORS

edefb41

PR-URL: #41234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

build: improve readability of texts in workflows

011c5f6

PR-URL: #40988 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

child_process: add support for URL to cp.fork

ef6f98c

PR-URL: #41225 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

test: improve test coverage of dns/promises

f067876

PR-URL: #41133 Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>

doc: make function signature comply with JSDoc comment

e27e827

PR-URL: #41242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

stream: fix enqueue race condition on esm modules

3dc6564

stream: use nextTick on close PR-URL: #40901 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

async_hooks: fix AsyncLocalStorage in unhandledRejection cases

56345a3

PR-URL: #41202 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

policy: add missing JSDoc @PARAM entry

e60187d

PR-URL: #41239 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

esm: reconcile JSDoc vs. actual parameter name

5ebe086

PR-URL: #41238 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

fs: correct param names in JSDoc comments

0951bd9

PR-URL: #41237 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

test: correct param name in JSDoc comment

8f08328

PR-URL: #41241 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

lib: remove spurious JSDoc entry

24fbbf2

PR-URL: #41240 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022

targos added the v17.x label Jan 17, 2022

ljharb added a commit to tape-testing/tape that referenced this pull request Jan 17, 2022

[meta] fix prelint so it does not fail outside of a git repo

b9959f8

per nodejs/node#41557 (comment)

mcollina approved these changes Jan 18, 2022

View reviewed changes

richardlau approved these changes Jan 18, 2022

View reviewed changes

targos added 2 commits January 18, 2022 14:23

targos force-pushed the v17.4.0-proposal branch from d54eed9 to 5b59e14 Compare January 18, 2022 13:29

richardlau approved these changes Jan 18, 2022

View reviewed changes

danielleadams approved these changes Jan 18, 2022

View reviewed changes

targos merged commit 5b59e14 into v17.x Jan 18, 2022

targos added a commit that referenced this pull request Jan 18, 2022

Working on v17.4.1

871a4a2

PR-URL: #41557

targos mentioned this pull request Jan 18, 2022

Blog: v17.4.0 release post nodejs/nodejs.org#4371

Merged

targos added a commit to targos/nodejs.org that referenced this pull request Jan 18, 2022

Blog: v17.4.0 release post

e7605cf

Refs: nodejs/node#41557

targos deleted the v17.4.0-proposal branch January 18, 2022 15:15

targos added a commit to nodejs/nodejs.org that referenced this pull request Jan 18, 2022

Blog: v17.4.0 release post (#4371 )

5e31c72

Refs: nodejs/node#41557

ljharb added a commit to tape-testing/tape that referenced this pull request Jan 26, 2022

[meta] fix prelint so it does not fail outside of a git repo

a09133e

per nodejs/node#41557 (comment)

v17.4.0 release proposal by targos · Pull Request #41557 · nodejs/node · GitHub

Uh oh!

Uh oh!

v17.4.0 release proposal - #41557

v17.4.0 release proposal#41557
targos merged 165 commits into
v17.xfrom
v17.4.0-proposal

targos commented Jan 16, 2022 •
edited
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 17, 2022

Uh oh!

targos commented Jan 17, 2022

Uh oh!

ljharb commented Jan 17, 2022

Uh oh!

aduh95 commented Jan 17, 2022

Uh oh!

targos commented Jan 17, 2022

Uh oh!

ljharb commented Jan 17, 2022

Uh oh!

nodejs-github-bot commented Jan 18, 2022

Uh oh!

targos commented Jan 18, 2022

Uh oh!

targos commented Jan 18, 2022

Uh oh!

mcollina left a comment

Uh oh!

targos commented Jan 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v17.4.0 release proposal by targos · Pull Request #41557 · nodejs/node · GitHub

Uh oh!

Uh oh!

v17.4.0 release proposal - #41557

v17.4.0 release proposal#41557targos merged 165 commits intov17.xnodejs/node:v17.xfrom v17.4.0-proposalnodejs/node:v17.4.0-proposalCopy head branch name to clipboard

Conversation

targos commented Jan 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Jan 17, 2022

Uh oh!

targos commented Jan 17, 2022

Uh oh!

ljharb commented Jan 17, 2022

Uh oh!

aduh95 commented Jan 17, 2022

Uh oh!

targos commented Jan 17, 2022

Uh oh!

ljharb commented Jan 17, 2022

Uh oh!

nodejs-github-bot commented Jan 18, 2022

Uh oh!

targos commented Jan 18, 2022

Uh oh!

targos commented Jan 18, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Jan 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

v17.4.0 release proposal#41557
targos merged 165 commits into
v17.xfrom
v17.4.0-proposal

targos commented Jan 16, 2022 •
edited
Loading