FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

node-api: add missing initialization of last error by mhdawson · Pull Request #41290 · nodejs/node · GitHub

/ node Public

node-api: add missing initialization of last error - #41290

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:coverity-9
Closed

node-api: add missing initialization of last error#41290
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:coverity-9

Conversation

Copy link
Copy Markdown
Member
  • Add missing initiatlization of last error which
    was reported by coverity.

Signed-off-by: Michael Dawson mdawson@devrus.com

- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

nodejs-github-bot commented Dec 22, 2021
edited by mhdawson
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/n-api

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 22, 2021
lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

mhdawson commented Jan 4, 2022

Copy link
Copy Markdown
Member Author

Looks like CI is complete even though UI still shows one check as pending, going to land.

mhdawson added a commit that referenced this pull request Jan 4, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

mhdawson commented Jan 4, 2022

Copy link
Copy Markdown
Member Author

Landed in 3f403e5

mhdawson closed this Jan 4, 2022
targos pushed a commit that referenced this pull request Jan 14, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41290
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL