test: mark test-performance-eventloopdelay flaky - #41409
Merged
nodejs-github-bot merged 1 commit intoJan 6, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Refs: nodejs#41286 This is one of the remaining high indicende failures in the CI. Mark as flaky while it is investigated. Signed-off-by: Michael Dawson <mdawson@devrus.com>
Copy link
Copy Markdown
Member
Author
|
This and the windows recursive remove dir seemed to be the cause of many of the recent failures which did not look like build/machine type failures. |
Sorry, something went wrong.
Trott
approved these changes
Jan 5, 2022
richardlau
approved these changes
Jan 5, 2022
Copy link
Copy Markdown
Member
|
FWIW this may have been introduced by 23637e9 (in case anyone is able to make more progress). FYI @jasnell |
Sorry, something went wrong.
lpinca
approved these changes
Jan 5, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'd like to suggest a fast track on this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
19 tasks
This was referenced Jan 7, 2022
22 tasks
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Refs: #41286 This is one of the remaining high indicende failures in the CI. Mark as flaky while it is investigated. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41409 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Refs: #41286 This is one of the remaining high indicende failures in the CI. Mark as flaky while it is investigated. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41409 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #41286
This is one of the remaining high indicende failures
in the CI. Mark as flaky while it is investigated.
Signed-off-by: Michael Dawson mdawson@devrus.com