doc: include stack trace difference in ES modules - #41157
Closed
thebergamo wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
reviewed
Dec 13, 2021
This change highlights in the docs difference between stack traces for CommonJS modules and ES Modules. Fixes: nodejs#39787
Copy link
Copy Markdown
Contributor
Author
|
I wasn't sure which commit message I should use in case of accepting those changes you proposed @aduh95 so I just made them in my code and pushed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
/cc @nodejs/modules |
Sorry, something went wrong.
jasnell
approved these changes
Dec 17, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change highlihts in the docs difference between stack traces for CJS modules and ES Modules.
Fixes: #39787