doc: update Abstract Equality Comparison text in assert.md - #41375
Merged
nodejs-github-bot merged 9 commits intoJan 5, 2022
Merged
doc: update Abstract Equality Comparison text in assert.md#41375nodejs-github-bot merged 9 commits into
nodejs-github-bot merged 9 commits into
Conversation
benjamingr
approved these changes
Jan 2, 2022
aduh95
reviewed
Jan 2, 2022
Comment thread
doc/api/assert.md
Outdated
* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits
aduh95
approved these changes
Jan 2, 2022
Comment thread
doc/api/assert.md
Outdated
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
tniessen
reviewed
Jan 2, 2022
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I am ∓0 on removing the term and link. It might be easier for readers to understand why the operator is important and how it differs from === if there was a link to the spec or to MDN or a term they could look up.
Sorry, something went wrong.
Comment thread
doc/api/assert.md
Outdated
Comment thread
doc/api/assert.md
Outdated
Comment thread
doc/api/assert.md
Outdated
Comment thread
doc/api/assert.md
Outdated
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>
Co-authored-by: Tobias Nießen <tniessen@users.noreply.github.com>
Copy link
Copy Markdown
Member
Author
We could use the relevant MDN link: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Equality |
Sorry, something went wrong.
lpinca
approved these changes
Jan 3, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41375 ✔ Done loading data for nodejs/node/pull/41375 ----------------------------------- PR info ------------------------------------ Title doc: update Abstract Equality Comparison text in assert.md (#41375) Author Rich Trott (@Trott) Branch Trott:abstract -> nodejs:master Labels assert, doc, commit-queue-squash Commits 9 - doc: update Abstract Equality Comparison text in assert.md - fixup! doc: update Abstract Equality Comparison text in assert.md - fixup! fixup! doc: update Abstract Equality Comparison text in assert.md - fixup! fixup! fixup! doc: update Abstract Equality Comparison text in… - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41375 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41375 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 02 Jan 2022 06:58:44 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41375#pullrequestreview-842388254 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41375#pullrequestreview-842433313 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41375#pullrequestreview-843025193 ⚠ This PR was merged on Wed, 05 Jan 2022 20:35:02 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1660097913 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41375 ✔ Done loading data for nodejs/node/pull/41375 ----------------------------------- PR info ------------------------------------ Title doc: update Abstract Equality Comparison text in assert.md (#41375) Author Rich Trott (@Trott) Branch Trott:abstract -> nodejs:master Labels assert, doc, commit-queue-failed, commit-queue-squash Commits 9 - doc: update Abstract Equality Comparison text in assert.md - fixup! doc: update Abstract Equality Comparison text in assert.md - fixup! fixup! doc: update Abstract Equality Comparison text in assert.md - fixup! fixup! fixup! doc: update Abstract Equality Comparison text in… - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41375 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41375 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 02 Jan 2022 06:58:44 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41375#pullrequestreview-842388254 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41375#pullrequestreview-842433313 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41375#pullrequestreview-843025193 ⚠ This PR was merged on Wed, 05 Jan 2022 20:35:02 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1660166904 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41375 ✔ Done loading data for nodejs/node/pull/41375 ----------------------------------- PR info ------------------------------------ Title doc: update Abstract Equality Comparison text in assert.md (#41375) Author Rich Trott (@Trott) Branch Trott:abstract -> nodejs:master Labels assert, doc, commit-queue-failed, commit-queue-squash Commits 9 - doc: update Abstract Equality Comparison text in assert.md - fixup! doc: update Abstract Equality Comparison text in assert.md - fixup! fixup! doc: update Abstract Equality Comparison text in assert.md - fixup! fixup! fixup! doc: update Abstract Equality Comparison text in… - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md - Update doc/api/assert.md Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41375 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41375 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 02 Jan 2022 06:58:44 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41375#pullrequestreview-842388254 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41375#pullrequestreview-842433313 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41375#pullrequestreview-843025193 ⚠ This PR was merged on Wed, 05 Jan 2022 20:35:02 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1660206628 |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 5, 2022
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 8, 2022
Refs: #41375 (comment) PR-URL: #41413 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits PR-URL: #41375 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Refs: #41375 (comment) PR-URL: #41413 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits PR-URL: #41375 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Remove link to ECMAScript specification because the term Abstract Equality Comparison is no longer used there. * Edit surprising-results material * Other minor edits PR-URL: #41375 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Refs: #41375 (comment) PR-URL: #41413 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.