FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: correct param names in JSDoc comments by Trott · Pull Request #41237 · nodejs/node · GitHub

/ node Public

fs: correct param names in JSDoc comments - #41237

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:fs-jsdoc
Dec 21, 2021
Merged

fs: correct param names in JSDoc comments#41237
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:fs-jsdoc

Conversation

Trott commented Dec 19, 2021

Copy link
Copy Markdown
Member

No description provided.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 19, 2021
nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 19, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. We might want to also get into a consistent state between the different functions and rename p in e.g., realpth() as well.

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Dec 21, 2021
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2021
nodejs-github-bot merged commit 1d34f0f into nodejs:master Dec 21, 2021

Copy link
Copy Markdown
Collaborator

Landed in 1d34f0f

Trott deleted the fs-jsdoc branch December 21, 2021 18:03
targos pushed a commit that referenced this pull request Jan 14, 2022
PR-URL: #41237
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41237
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41237
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams mentioned this pull request Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL