FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add @RaisinTen to the TSC by mhdawson · Pull Request #41419 · nodejs/node · GitHub

/ node Public

doc: add @RaisinTen to the TSC - #41419

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:add-tsc
ConversationCommits (1)ChecksFiles changed
Closed

doc: add @RaisinTen to the TSC#41419
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:add-tsc

Conversation

mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member

Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson mdawson@devrus.com

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 6, 2022

mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

I'll land once I get through the onboarding steps (assuming there are enough approvals/waiting time is complete by then)

mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

Believe we can fast track this.

mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 6, 2022

github-actions Bot commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.

apapirovski approved these changes Jan 6, 2022
View reviewed changes

apapirovski left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Now that we have the vote directory in nodejs/tsc, should we create that PR first and then reference it here?

Although I guess the json is mostly for bookkeeping, since the vote happens in the issue thread... which makes me think, should our votes just be PRs against the TSC repo? Would simplify the automation too.

Edit: I suppose upon further reflection, a decent % of our votes are not binary which would make the PR format not particularly helpful.

bnb changed the title doc: add @RaisenTen to the TSC doc: add @RaisinTen to the TSC Jan 6, 2022

bnb commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

(updated the title to match the other PR, there was an error in the name)

richardlau commented Jan 6, 2022

Copy link
Copy Markdown
Member

(updated the title to match the other PR, there was an error in the name)

@mhdawson The commit title would need to be updated as well.

tniessen approved these changes Jan 6, 2022
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Welcome! 🎉

doc: add @RaisinTen to the TSC
66b1054 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <mdawson@devrus.com>

mhdawson commented Jan 6, 2022

Copy link
Copy Markdown
Member Author

@richardlau fixed

aduh95 mentioned this pull request Jan 7, 2022
Closed

mhdawson commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

Ok, added to all required groups, created PRs to add to emails.

mhdawson added a commit that referenced this pull request Jan 7, 2022
doc: add @RaisinTen to the TSC
46f4d5e 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41419
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>

mhdawson commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

Landed in 46f4d5e

mhdawson closed this Jan 7, 2022

mhdawson commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

@RaisinTen Welcome !

targos pushed a commit that referenced this pull request Jan 14, 2022
doc: add @RaisinTen to the TSC
d3111bf 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41419
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
doc: add @RaisinTen to the TSC
66b90f9 
Refs: nodejs/TSC#1141

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41419
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnb bnb approved these changes
Trott Trott approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
BethGriggs BethGriggs approved these changes
aduh95 aduh95 approved these changes
+2 more reviewers
apapirovski apapirovski approved these changes
mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL