tls: use optional chaining to simplify checks - #41337
Merged
nodejs-github-bot merged 1 commit intoJan 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tniessen
approved these changes
Dec 27, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
lib/internal/tls/secure-context.js
| const pem = ( | ||
| val !== undefined && val !== null && | ||
| val.pem !== undefined ? val.pem : val); | ||
| val?.pem !== undefined ? val.pem : val); |
Copy link
Copy Markdown
There was a problem hiding this comment.
Suggested change
| val?.pem !== undefined ? val.pem : val); | |
| val?.pem ?? val); |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
What if val.pem is null?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Using ?? would change the current behavior. If we want to keep this a refactoring, we can't use ??. Now, if we know that val.pem can never be null, we can make that change safely - but maybe in a separate commit?
Sorry, something went wrong.
fhinkel
approved these changes
Dec 28, 2021
This was referenced Dec 30, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jan 6, 2022
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41337 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #41337 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41337 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #41170 (review)