FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: correct my name in AUTHORS by JakobJingleheimer · Pull Request #41444 · nodejs/node · GitHub

/ node Public

meta: correct my name in AUTHORS - #41444

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
JakobJingleheimer:patch-1
Jan 10, 2022
ConversationCommits (2)ChecksFiles changed
Merged

meta: correct my name in AUTHORS#41444
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
JakobJingleheimer:patch-1

Conversation

JakobJingleheimer commented Jan 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

My surname is currently missing in AUTHORS list.

JakobJingleheimer changed the title Correct my name in AUTHORS fixup: correct my name in AUTHORS Jan 8, 2022
JakobJingleheimer force-pushed the patch-1 branch 2 times, most recently from 32e57a0 to 7711e5e Compare January 8, 2022 10:11
JakobJingleheimer changed the title fixup: correct my name in AUTHORS meta: correct my name in AUTHORS Jan 8, 2022
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 8, 2022

github-actions Bot commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

targos suggested changes Jan 8, 2022
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Did you rename the file?
There needs to be a change in .mailmap. AUTHORS is automatically generated using it and the git log.

JakobJingleheimer commented Jan 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

What the… no, I didn't (mean to) rename the file. Last time I use GitHub's web editor (that field used to be for naming the branch—now a field for naming the branch is gone, and it's apparently to rename the file 😳)

I'll rename it back and update mailmap.

Thanks @targos

JakobJingleheimer commented Jan 8, 2022

Copy link
Copy Markdown
Member Author

@targos should I remove the correction in AUTHORS (or will it just get overwritten)? Is it possible to correct it at all? My surname got omitted in some commit (that landed a while ago), and that's what go added to AUTHORS.

entry to .mailmap added.

richardlau approved these changes Jan 8, 2022
View reviewed changes

richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Refs: #40504 (comment)

Trott reviewed Jan 8, 2022
View reviewed changes
Comment thread .mailmap Outdated

Trott commented Jan 8, 2022

Copy link
Copy Markdown
Member

Did you rename the file? There needs to be a change in .mailmap. AUTHORS is automatically generated using it and the git log.

@targos Is this resolved now?

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 10, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 10, 2022
nodejs-github-bot merged commit f027463 into nodejs:master Jan 10, 2022

nodejs-github-bot commented Jan 10, 2022

Copy link
Copy Markdown
Collaborator

Landed in f027463

targos pushed a commit that referenced this pull request Jan 14, 2022
meta: correct my name in AUTHORS
e1ff452 
PR-URL: #41444
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
meta: correct my name in AUTHORS
e83e416 
PR-URL: #41444
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
richardlau richardlau approved these changes
Ayase-252 Ayase-252 approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL