FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add usage recommendation for writable._destroy by RafaelGSS · Pull Request #41040 · nodejs/node · GitHub

/ node Public

doc: add usage recommendation for writable._destroy - #41040

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
RafaelGSS:docs/writable-destroy
Dec 22, 2021
ConversationCommits (1)ChecksFiles changed
Merged

doc: add usage recommendation for writable._destroy#41040
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
RafaelGSS:docs/writable-destroy

Conversation

RafaelGSS commented Nov 30, 2021

Copy link
Copy Markdown
Member

Address: #40377

nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 30, 2021
mcollina approved these changes Nov 30, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mcollina requested a review from ronag November 30, 2021 16:37

lpinca commented Nov 30, 2021

Copy link
Copy Markdown
Member

In light of #40773 is this still needed? I guess we should eventually revert this when #40773 lands.

RafaelGSS commented Nov 30, 2021

Copy link
Copy Markdown
Member Author

In light of #40773 is this still needed? I guess we should eventually revert this when #40773 lands.

I think that it still needs to be backported.

RafaelGSS commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

Any updates on this?

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2021
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2021
nodejs-github-bot merged commit 5016181 into nodejs:master Dec 22, 2021

nodejs-github-bot commented Dec 22, 2021

Copy link
Copy Markdown
Collaborator

Landed in 5016181

RafaelGSS mentioned this pull request Dec 22, 2021
Closed
targos pushed a commit that referenced this pull request Jan 14, 2022
doc: add usage recommendation for writable._destroy
29563ab 
PR-URL: #41040
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
doc: add usage recommendation for writable._destroy
b8a7f63 
PR-URL: #41040
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
doc: add usage recommendation for writable._destroy
aa04a2c 
PR-URL: #41040
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ronag Awaiting requested review from ronag
+1 more reviewer
bell47 bell47 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL