tools: consolidate update-authors.js logic - #41255
Merged
nodejs-github-bot merged 1 commit intoDec 23, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use a single regex and fewer logical branches in the code.
Copy link
Copy Markdown
Member
Author
|
I tested this by making AUTHORS a zero-length file and running the script to confirm that it produced identical content to the current script. |
Sorry, something went wrong.
jasnell
approved these changes
Dec 21, 2021
VoltrexKeyva
approved these changes
Dec 22, 2021
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Use a single regex and fewer logical branches in the code. PR-URL: #41255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Use a single regex and fewer logical branches in the code. PR-URL: #41255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Use a single regex and fewer logical branches in the code. PR-URL: #41255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a single regex and fewer logical branches in the code.