FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document that `require.main` may be `undefined` by aduh95 · Pull Request #41384 · nodejs/node · GitHub

/ node Public

doc: document that require.main may be undefined - #41384

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
aduh95:require-main-undefined
Jan 5, 2022
Merged

doc: document that require.main may be undefined#41384
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
aduh95:require-main-undefined

Conversation

aduh95 commented Jan 2, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/modules

nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Jan 2, 2022
aduh95 added doc Issues and PRs related to the documentations. and removed doc Issues and PRs related to the documentations. labels Jan 2, 2022
Comment thread doc/api/modules.md Outdated
Comment thread doc/api/modules.md Outdated
Comment thread doc/api/modules.md Outdated

tniessen commented Jan 3, 2022

Copy link
Copy Markdown
Member

Thanks for updating it @aduh95! :)

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 3, 2022
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2022
nodejs-github-bot merged commit 090cdb6 into nodejs:master Jan 5, 2022

Copy link
Copy Markdown
Collaborator

Landed in 090cdb6

aduh95 deleted the require-main-undefined branch January 5, 2022 10:56
targos pushed a commit that referenced this pull request Jan 14, 2022
PR-URL: #41384
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #41384
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41384
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL