build: remove Python 2 workaround - #41357
Merged
nodejs-github-bot merged 1 commit intoJan 1, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`.
Copy link
Copy Markdown
Member
Author
|
/ping @nodejs/v8-update in case this is premature |
Sorry, something went wrong.
tniessen
approved these changes
Dec 30, 2021
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
V8 CI is green. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Dec 30, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
26 tasks
gengjiawen
approved these changes
Dec 31, 2021
Lxxyx
approved these changes
Dec 31, 2021
24 tasks
This was referenced Jan 2, 2022
18 tasks
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: #41357 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: #41357 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: #41357 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove workaround for Python 2.
I confirmed that V8 build still works by running ./configure.py && make v8.