FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable by dsanders11 · Pull Request #41235 · nodejs/node · GitHub

/ node Public

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable - #41235

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
dsanders11:patch-1
Jan 6, 2022
ConversationCommits (1)ChecksFiles changed
Merged

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable#41235
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
dsanders11:patch-1

Conversation

dsanders11 commented Dec 19, 2021 •
edited by richardlau
Loading

Copy link
Copy Markdown
Contributor

Looks like VCBUILD_PYTHON_LOCATION went stale at some point, and isn't read anywhere (searching the repo shows this is the only usage).

Refs: #18621

nodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Dec 19, 2021
dsanders11 changed the title build,tools,win: Trim unused VCBUILD_PYTHON_LOCATION variable build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable Dec 19, 2021
RaisinTen approved these changes Dec 19, 2021
View reviewed changes

RaisinTen left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Uses of VCBUILD_PYTHON_LOCATION were removed in #18621, LGTM.

This comment has been minimized.

Sign in to view
RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 19, 2021
This was referenced Dec 20, 2021
Open
Open

This comment has been minimized.

Sign in to view
This was referenced Dec 22, 2021
Open
Open
Open
Open
Open
Open

This comment has been minimized.

Sign in to view
This was referenced Dec 28, 2021
Open
Open
Open
Open
Open
Open
Open
github-actions Bot mentioned this pull request Jan 4, 2022
Open
25 tasks
github-actions Bot mentioned this pull request Jan 5, 2022
Open
26 tasks

nodejs-github-bot commented Jan 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41757/

RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
nodejs-github-bot merged commit 79b21ee into nodejs:master Jan 6, 2022

nodejs-github-bot commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Landed in 79b21ee

dsanders11 deleted the patch-1 branch January 6, 2022 22:24
targos pushed a commit that referenced this pull request Jan 14, 2022
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
2233f31 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
fc38d15 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
richardlau richardlau approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL