FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve test coverage of dns/promises by kuriyosh · Pull Request #41133 · nodejs/node · GitHub

/ node Public

test: improve test coverage of dns/promises - #41133

Merged
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
kuriyosh:dns-options-test
Dec 19, 2021
ConversationCommits (2)ChecksFiles changed
Merged

test: improve test coverage of dns/promises#41133
nodejs-github-bot merged 2 commits into
nodejs:masterfrom
kuriyosh:dns-options-test

Conversation

kuriyosh commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

This improves a test coverage in lib/internal/dns/promises.
It tests emitting warning when the options types of lookup method are invalid.

ref: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 10, 2021
Mesteery added the dns Issues and PRs related to the dns subsystem. label Dec 10, 2021

jasnell commented Dec 10, 2021

Copy link
Copy Markdown
Member

Looks like there are some relevant test failures that need to be looked at! :-)

kuriyosh force-pushed the dns-options-test branch 2 times, most recently from 0c67e16 to a197004 Compare December 11, 2021 01:59
kuriyosh commented Dec 11, 2021
View reviewed changes
Comment thread test/parallel/test-dns-lookup-promises-options-deprecated.js Outdated

kuriyosh Dec 11, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This test only check whether DeprecationWarning is emitted when hints is not a number.
Since the valid string value of hints depends on the OS environment, give an invalid string value here and assert the error.

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Dec 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41463/

Ayase-252 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 13, 2021
This was referenced Dec 15, 2021
Open
Open
Open
Open
Open
aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 19, 2021
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
nodejs-github-bot merged commit 9b903d1 into nodejs:master Dec 19, 2021

nodejs-github-bot commented Dec 19, 2021

Copy link
Copy Markdown
Collaborator

Landed in 9b903d1

github-actions Bot mentioned this pull request Dec 20, 2021
Open
20 tasks
targos pushed a commit that referenced this pull request Jan 14, 2022
test: improve test coverage of dns/promises
f067876 
PR-URL: #41133
Refs: https://coverage.nodejs.org/coverage-18ff5832501b66b4/lib/internal/dns/promises.js.html#L116
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
targos mentioned this pull request Jan 16, 2022
Merged

danielleadams commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

@kuriyosh This caused a failed test when pulling into the v16.x release. Do you mind creating a backport PR?

kuriyosh commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

@danielleadams
Of course. Please ping me if I have any necessary actions.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
lpinca lpinca approved these changes
Ayase-252 Ayase-252 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL