stream: remove unused function argument - #41403
Merged
nodejs-github-bot merged 1 commit intoJan 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
watchClosed() is only ever called with an anonymous function for the action parameter. This anonymous funciton does not take any arguments. Remove unused argument from invocation of action().
This comment has been minimized.
ZYSzys
approved these changes
Jan 5, 2022
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
VoltrexKeyva
approved these changes
Jan 5, 2022
lpinca
approved these changes
Jan 5, 2022
This was referenced Jan 6, 2022
This was referenced Jan 8, 2022
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
watchClosed() is only ever called with an anonymous function for the action parameter. This anonymous funciton does not take any arguments. Remove unused argument from invocation of action(). PR-URL: #41403 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
watchClosed() is only ever called with an anonymous function for the action parameter. This anonymous funciton does not take any arguments. Remove unused argument from invocation of action(). PR-URL: #41403 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
watchClosed() is only ever called with an anonymous function for the
action parameter. This anonymous funciton does not take any arguments.
Remove unused argument from invocation of action().