doc: remove statement about client private keys - #41505
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This statement was objectively false. Clients usually only need to generate and/or own a private key if the server sends a CertificateRequest during the TLS handshake, which is not a common case.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/crypto |
Sorry, something went wrong.
panva
approved these changes
Jan 14, 2022
benjamingr
approved these changes
Jan 14, 2022
cjihrig
approved these changes
Jan 14, 2022
mhdawson
approved these changes
Jan 14, 2022
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
tniessen
added a commit
that referenced
this pull request
Jan 16, 2022
This statement was objectively false. Clients usually only need to generate and/or own a private key if the server sends a CertificateRequest during the TLS handshake, which is not a common case. PR-URL: #41505 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Copy link
Copy Markdown
Member
Author
|
Landed in b2edcfe, thanks for reviewing! |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jan 16, 2022
This statement was objectively false. Clients usually only need to generate and/or own a private key if the server sends a CertificateRequest during the TLS handshake, which is not a common case. PR-URL: #41505 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
This statement was objectively false. Clients usually only need to generate and/or own a private key if the server sends a CertificateRequest during the TLS handshake, which is not a common case. PR-URL: #41505 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This statement was objectively false. Clients usually only need to generate and/or own a private key if the server sends a CertificateRequest during the TLS handshake, which is not a common case.