test: remove broken wiki link from test/common doc - #41426
Merged
aduh95 merged 1 commit intoJan 14, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
richardlau
approved these changes
Jan 7, 2022
apapirovski
approved these changes
Jan 7, 2022
lpinca
approved these changes
Jan 7, 2022
Trott
approved these changes
Jan 8, 2022
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41426 ✔ Done loading data for nodejs/node/pull/41426 ----------------------------------- PR info ------------------------------------ Title test: remove broken wiki link from test/common doc (#41426) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch kuriyosh:remove-broken-link-intl -> nodejs:master Labels test, author ready, needs-ci Commits 1 - test: remove broken wiki link from test/common doc Committers 1 - kuriyosh PR-URL: https://github.com/nodejs/node/pull/41426 Reviewed-By: Richard Lau Reviewed-By: Anatoli Papirovski Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41426 Reviewed-By: Richard Lau Reviewed-By: Anatoli Papirovski Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 07 Jan 2022 06:40:32 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41426#pullrequestreview-846540007 ✔ - Anatoli Papirovski (@apapirovski) (TSC): https://github.com/nodejs/node/pull/41426#pullrequestreview-846732722 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41426#pullrequestreview-846949575 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41426#pullrequestreview-847114571 ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1676834514 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
IMO, it might not need a full CI run. Maybe we could narrow the scope of files which need full CI run to test/**/*.js? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
No, that's too narrow and would exclude any changes to the native code in the addons tests, non *.js fixtures (which look to also include some markdown files), status file updates and *.mjs files. You could potentially exclude just test/common/README.md. |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Jan 16, 2022
PR-URL: #41426 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41426 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This remove obsolete wiki link in test/common/README.md.