FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: fix workflow access to git history by Trott · Pull Request #41472 · nodejs/node · GitHub

/ node Public

build: fix workflow access to git history - #41472

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:history-fix
Jan 13, 2022
ConversationCommits (1)ChecksFiles changed
Merged

build: fix workflow access to git history#41472
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:history-fix

Conversation

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member

Refs: #41466

nodejs-github-bot commented Jan 11, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 11, 2022
Trott mentioned this pull request Jan 11, 2022
Closed

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Test run: https://github.com/nodejs/node/actions/runs/1681223387

Trott marked this pull request as draft January 11, 2022 07:08

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Test run: https://github.com/nodejs/node/actions/runs/1681223387

Nope, that didn't fix it. Converting this to draft mode.

This seems relevant:

warning: log for 'HEAD' only goes back to Tue, 11 Jan 2022 07:05:40 +0000
warning: log for 'HEAD' only goes back to Tue, 11 Jan 2022 07:05:40 +0000

Trott force-pushed the history-fix branch 3 times, most recently from ea8fb39 to 086216f Compare January 11, 2022 07:54
Trott marked this pull request as ready for review January 11, 2022 08:04

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Test action run: https://github.com/nodejs/node/actions/runs/1681411160

Trott commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Test action run: https://github.com/nodejs/node/actions/runs/1681411160

Test action worked as expected.

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 11, 2022
Trott requested a review from mhdawson January 11, 2022 08:08

github-actions Bot commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 11, 2022
Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 13, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 13, 2022
nodejs-github-bot merged commit 4b1ee04 into nodejs:master Jan 13, 2022

nodejs-github-bot commented Jan 13, 2022

Copy link
Copy Markdown
Collaborator

Landed in 4b1ee04

Trott deleted the history-fix branch January 14, 2022 03:27
targos pushed a commit that referenced this pull request Jan 14, 2022
build: fix workflow access to git history
3d88ea1 
Refs: #41466

PR-URL: #41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
build: fix workflow access to git history
6ffb1e8 
Refs: #41466

PR-URL: #41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnb bnb approved these changes
richardlau richardlau approved these changes
mhdawson Awaiting requested review from mhdawson

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL