src: gracefully handle errors in GetX509NameObject - #41490
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
addaleax
approved these changes
Jan 12, 2022
cjihrig
approved these changes
Jan 12, 2022
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jan 13, 2022
tniessen
added a commit
that referenced
this pull request
Jan 14, 2022
Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: #41490 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Member
Author
|
Landed in 4dd1f42, thanks for reviewing. |
Sorry, something went wrong.
tniessen
added a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
26 tasks
tniessen
deleted the
src-gracefully-handle-errors-in-getx509nameobject
branch
January 15, 2022 16:10
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41490 Co-authored-by: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When V8 reports an exception, fail gracefully instead of terminating the process in GetX509NameObject.
A huge thanks to @addaleax for pointing this out.
While this function was added as part of a security release (a336444), this patch does not affect security. Exceptions can realistically only occur due to custom setters on the Array prototype.