tools: fix argv bug in find-inactive-tsc.mjs - #41394
Merged
nodejs-github-bot merged 1 commit intoJan 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The argument supplied is expected to be text, not numeric. This wasn't causing issues with the automated job because it does not send an argument. It uses the default.
targos
approved these changes
Jan 4, 2022
cjihrig
approved these changes
Jan 4, 2022
richardlau
approved these changes
Jan 4, 2022
lpinca
approved these changes
Jan 4, 2022
antsmartian
approved these changes
Jan 5, 2022
tniessen
approved these changes
Jan 5, 2022
Lxxyx
approved these changes
Jan 5, 2022
apapirovski
approved these changes
Jan 6, 2022
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
The argument supplied is expected to be text, not numeric. This wasn't causing issues with the automated job because it does not send an argument. It uses the default. PR-URL: #41394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
The argument supplied is expected to be text, not numeric. This wasn't causing issues with the automated job because it does not send an argument. It uses the default. PR-URL: #41394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument supplied is expected to be text, not numeric.
This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.