build: fix commit-queue-rebase functionality - #41140
Merged
nodejs-github-bot merged 1 commit intoDec 11, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
For commit-queue-rebase only, commit-queue.sh uses `git push` which requires the credentials from the git checkout. Remove `persist-credentials: false` from this workflow.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
aduh95
approved these changes
Dec 11, 2021
BridgeAR
approved these changes
Dec 11, 2021
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
targos
approved these changes
Dec 11, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
For commit-queue-rebase only, commit-queue.sh uses `git push` which requires the credentials from the git checkout. Remove `persist-credentials: false` from this workflow. PR-URL: #41140 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
For commit-queue-rebase only, commit-queue.sh uses `git push` which requires the credentials from the git checkout. Remove `persist-credentials: false` from this workflow. PR-URL: #41140 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
For commit-queue-rebase only, commit-queue.sh uses `git push` which requires the credentials from the git checkout. Remove `persist-credentials: false` from this workflow. PR-URL: #41140 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
For commit-queue-rebase only, commit-queue.sh uses `git push` which requires the credentials from the git checkout. Remove `persist-credentials: false` from this workflow. PR-URL: #41140 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For commit-queue-rebase only, commit-queue.sh uses git push which
requires the credentials from the git checkout. Remove
persist-credentials: false from this workflow.