FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: disable warnings to fix flaky test by aduh95 · Pull Request #40739 · nodejs/node · GitHub

/ node Public

test: disable warnings to fix flaky test - #40739

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-flaky-json-warning-in-message
ConversationCommits (1)ChecksFiles changed
Closed

test: disable warnings to fix flaky test#40739
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:fix-flaky-json-warning-in-message

Conversation

aduh95 commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

Fixes: #40738

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2021
aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2021

This comment has been minimized.

Sign in to view
targos approved these changes Nov 6, 2021
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but do you know why the test doesn't fail all the time on all platforms?

targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 6, 2021

github-actions Bot commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

nodejs-github-bot commented Nov 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40741/

aduh95 commented Nov 6, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

LGTM, but do you know why the test doesn't fail all the time on all platforms?

Note sure, it could be related to something like a race condition between the warning being emitted asynchronously and the process crashing.

github-actions Bot mentioned this pull request Nov 7, 2021
Open
46 tasks

nodejs-github-bot commented Nov 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40751/

Mesteery added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 7, 2021
github-actions Bot mentioned this pull request Nov 8, 2021
Open
46 tasks

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40762/

targos mentioned this pull request Nov 8, 2021
Closed

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40765/

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40766/

nodejs-github-bot commented Nov 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40770/

targos commented Nov 8, 2021

Copy link
Copy Markdown
Member

Landed in a420da6

targos closed this Nov 8, 2021
targos pushed a commit that referenced this pull request Nov 8, 2021
test: disable warnings to fix flaky test
a420da6 
Fixes: #40738

PR-URL: #40739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 8, 2021
test: disable warnings to fix flaky test
e58cce4 
Fixes: #40738

PR-URL: #40739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 8, 2021
Merged
aduh95 deleted the fix-flaky-json-warning-in-message branch November 8, 2021 18:00
This was referenced Nov 9, 2021
Open
Open
Open
This was referenced Nov 12, 2021
Open
Open

danielleadams commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

@aduh95 I think this is related to #40250. Do you mind backporting this to v16.x-staging too?

aduh95 mentioned this pull request Jan 30, 2022
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Jan 31, 2022
test: disable warnings to fix flaky test
0d728a3 
Fixes: nodejs#40738

PR-URL: nodejs#40739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
test: disable warnings to fix flaky test
b4fea14 
Fixes: #40738

PR-URL: #40739
Backport-PR-URL: #41776
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test - esm_display_syntax_error_import_json_named_export

6 participants

Back | FazBrowse Home | New Git URL