FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: drain Transform with 0 highWaterMark by ronag · Pull Request #40947 · nodejs/node · GitHub

/ node Public

stream: drain Transform with 0 highWaterMark - #40947

Closed
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:transform-hwm-0
ConversationCommits (2)ChecksFiles changed
Closed

stream: drain Transform with 0 highWaterMark#40947
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:transform-hwm-0

Conversation

ronag commented Nov 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #40935

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 24, 2021
ronag changed the title Transform hwm 0 stream: drain Transform with 0 highWaterMark Nov 24, 2021
ronag requested a review from mcollina November 24, 2021 08:43
ronag added lts-watch-v16.x stream Issues and PRs related to the stream subsystem. and removed meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 24, 2021
mcollina approved these changes Nov 24, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag commented Nov 24, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021

This comment has been minimized.

Sign in to view
lpinca approved these changes Nov 24, 2021
View reviewed changes
Comment thread test/parallel/test-stream-passthrough-drain.js Outdated
Update test/parallel/test-stream-passthrough-drain.js
f88c666 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Nov 24, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021

This comment has been minimized.

Sign in to view
github-actions Bot mentioned this pull request Nov 25, 2021
Open
38 tasks

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
github-actions Bot mentioned this pull request Nov 26, 2021
Open
33 tasks

This comment has been minimized.

Sign in to view
github-actions Bot mentioned this pull request Nov 27, 2021
Open
27 tasks

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Nov 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41153/

ronag commented Nov 27, 2021

Copy link
Copy Markdown
Member Author

Landed in 37f1dd9

ronag closed this Nov 27, 2021
ronag added a commit that referenced this pull request Nov 27, 2021
stream: drain Transform with 0 highWaterMark
37f1dd9 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Nov 28, 2021
Open
Open
targos pushed a commit that referenced this pull request Nov 29, 2021
stream: drain Transform with 0 highWaterMark
86d1c0b 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos mentioned this pull request Nov 29, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
stream: drain Transform with 0 highWaterMark
ea8a455 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
stream: drain Transform with 0 highWaterMark
3b1c012 
Fixes: #40935

PR-URL: #40947
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams mentioned this pull request Feb 1, 2022
Merged
paulrutter mentioned this pull request Mar 25, 2022
Closed

kanongil commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

This fix is faulty and causes a regression in my stream code, which can no longer use the highWaterMark: 0 option. This issue is still present in the latest releases, including v18! #42457 seems to detail the issue. Essentially this "fix" removes all backpressure.

I explicitly test against this here, since my transform stream relies on it working.

I guess I will have to continue running node 14 on my servers.

benjamingr commented Jun 27, 2022

Copy link
Copy Markdown
Member

@kanongil can you please open a new separate issue (pointing to this PR) and I'll ping stream maintainers?

kanongil commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

@benjamingr It's already described in #42457, which I have amended with my info.

kanongil mentioned this pull request Jul 1, 2022
Closed
kanongil added a commit to kanongil/node-1 that referenced this pull request Jul 1, 2022
stream: fix Transform with hwm 0 regression
b8a1698 
Fixes: nodejs#40935
Refs: nodejs#40947
Refs: nodejs#42457
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stream.PassThrough not draining (from Node 16)

8 participants

Back | FazBrowse Home | New Git URL