FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: pipeline should drain empty readable by ronag · Pull Request #40654 · nodejs/node · GitHub

/ node Public

stream: pipeline should drain empty readable - #40654

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:drain-empty-readable
ConversationCommits (1)ChecksFiles changed
Closed

stream: pipeline should drain empty readable#40654
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:drain-empty-readable

Conversation

ronag commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

Related: #40653

ronag added the stream Issues and PRs related to the stream subsystem. label Oct 29, 2021
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2021

ronag commented Oct 29, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

ronag force-pushed the drain-empty-readable branch from 9e5a829 to 8d15eb2 Compare October 29, 2021 11:25
ronag requested a review from mcollina October 29, 2021 11:25
ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
mcollina approved these changes Oct 29, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Oct 31, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 31, 2021

nodejs-github-bot commented Oct 31, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40589/

This was referenced Nov 1, 2021
Open
Open
Open
ronag requested a review from jasnell November 4, 2021 20:53

nodejs-github-bot commented Nov 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40714/

github-actions Bot mentioned this pull request Nov 5, 2021
Open
43 tasks

nodejs-github-bot commented Nov 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40729/

mcollina approved these changes Nov 5, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag commented Nov 5, 2021

Copy link
Copy Markdown
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2789/

This was referenced Nov 6, 2021
Open
Open
Open
Open
Open
ronag requested a review from lpinca November 10, 2021 15:23

nodejs-github-bot commented Nov 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40821/

github-actions Bot mentioned this pull request Nov 12, 2021
Open
35 tasks

nodejs-github-bot commented Nov 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40846/

github-actions Bot mentioned this pull request Nov 13, 2021
Open
31 tasks

ronag commented Nov 13, 2021

Copy link
Copy Markdown
Member Author

@nodejs/tsc this needs another TSC approval

nodejs-github-bot commented Nov 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40863/

github-actions Bot mentioned this pull request Nov 14, 2021
Open
41 tasks

Trott commented Nov 14, 2021

Copy link
Copy Markdown
Member

This needs a rebase against the master branch for one of the tests to pass on the Pi devices.

stream: pipeline should drain empty readable
181bdf9 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)
ronag force-pushed the drain-empty-readable branch from 8d15eb2 to 181bdf9 Compare November 14, 2021 13:51
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2021

nodejs-github-bot commented Nov 14, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40881/

github-actions Bot mentioned this pull request Nov 15, 2021
Open
44 tasks

nodejs-github-bot commented Nov 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40898/

github-actions Bot mentioned this pull request Nov 16, 2021
Open
40 tasks

nodejs-github-bot commented Nov 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40923/

This was referenced Nov 17, 2021
Open
Open
ronag removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 18, 2021

ronag commented Nov 18, 2021

Copy link
Copy Markdown
Member Author

@mcollina I don't think this should be semver-major. wdyt?

mcollina approved these changes Nov 18, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, ok

ronag commented Nov 18, 2021

Copy link
Copy Markdown
Member Author

Landed in 0a3a601

ronag closed this Nov 18, 2021
ronag added a commit that referenced this pull request Nov 18, 2021
stream: pipeline should drain empty readable
0a3a601 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
github-actions Bot mentioned this pull request Nov 19, 2021
Open
31 tasks
targos pushed a commit that referenced this pull request Nov 21, 2021
stream: pipeline should drain empty readable
16ee842 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
stream: pipeline should drain empty readable
644b9a9 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
stream: pipeline should drain empty readable
c9f1398 
This simplifies some cases where the last stream is a Duplex
without any expected output.

await pipeline(readable, duplex)

PR-URL: #40654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL