FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: return readable stream on promisified pipeline by ronag · Pull Request #40653 · nodejs/node · GitHub

/ node Public

stream: return readable stream on promisified pipeline - #40653

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:promise-pipeline-return
ConversationCommits (1)ChecksFiles changed
Closed

stream: return readable stream on promisified pipeline#40653
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:promise-pipeline-return

Conversation

ronag commented Oct 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Otherwise it's impossible to read the remaining data...

ronag requested review from lpinca and mcollina October 29, 2021 10:50
ronag added semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem. labels Oct 29, 2021

ronag commented Oct 29, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2021
ronag force-pushed the promise-pipeline-return branch from 56ec619 to 088af2a Compare October 29, 2021 10:51
ronag removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021

ronag commented Oct 29, 2021

Copy link
Copy Markdown
Member Author

@mcollina semver minor or major? wdyt?

ronag mentioned this pull request Oct 29, 2021
Closed
ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2021
lpinca reviewed Oct 31, 2021
View reviewed changes
Comment thread lib/stream/promises.js Outdated
ronag mentioned this pull request Nov 1, 2021
Open
ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 4, 2021
ronag force-pushed the promise-pipeline-return branch from aea84c2 to 088af2a Compare November 4, 2021 20:57
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021

nodejs-github-bot commented Nov 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40715/

mcollina requested changes Nov 4, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you update the docs?

This was referenced Nov 5, 2021
Open
Open
Open
ronag closed this Nov 7, 2021

ronag commented Nov 7, 2021

Copy link
Copy Markdown
Member Author

Probably better to just use stream.compose in this scenario.

github-actions Bot mentioned this pull request Nov 8, 2021
Open
46 tasks
joyeecheung mentioned this pull request Nov 8, 2021
Closed
This was referenced Nov 9, 2021
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca left review comments
mcollina mcollina requested changes
+1 more reviewer
Mesteery Mesteery left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL