assert: use stricter stack frame detection in .ifError() - #41006
Merged
nodejs-github-bot merged 1 commit intoDec 6, 2021
Merged
assert: use stricter stack frame detection in .ifError()#41006nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
reviewed
Nov 28, 2021
Comment thread
lib/assert.js
Outdated
This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
force-pushed
the
stricter-stack-frame-detection
branch
from
134fd89 to
55445c1
Compare
November 28, 2021 19:14
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Nov 30, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41006 ✔ Done loading data for nodejs/node/pull/41006 ----------------------------------- PR info ------------------------------------ Title assert: use stricter stack frame detection in .ifError() (#41006) Author Ruben Bridgewater (@BridgeAR) Branch BridgeAR:stricter-stack-frame-detection -> nodejs:master Labels assert, author ready, needs-ci Commits 1 - assert: use stricter stack frame detection in .ifError() Committers 1 - Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/41006 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41006 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 28 Nov 2021 18:56:20 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41006#pullrequestreview-819146559 ✖ This PR needs to wait 113 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-12-01T00:32:38Z: https://ci.nodejs.org/job/node-test-pull-request/41245/ - Querying data for job/node-test-pull-request/41245/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1523758566 |
Sorry, something went wrong.
This was referenced Dec 3, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41006 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41006 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41006 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
This makes sure arbitrary stack traces are not handled as stack frames. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #41006 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure arbitrary stack traces are not handled as stack
frames.
Signed-off-by: Ruben Bridgewater ruben@bridgewater.de