fs: fix length option being ignored during read() - #40906
Merged
nodejs-github-bot merged 3 commits intoDec 10, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Currently, `length` in an options object is ignored.
ronag
reviewed
Nov 21, 2021
Comment thread
lib/internal/fs/promises.js
Outdated
ronag
requested changes
Nov 21, 2021
ronag
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Needs a test
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for sending this PR, this looks indeed like an oversight. Can you please add test cases in test/parallel/test-fs-promises-file-handle-read.js where the length argument is different from buffer.byteLength, and verify that the number of read bytes is as expected? |
Sorry, something went wrong.
Co-authored-by: Robert Nagy <ronagy@icloud.com>
ronag
approved these changes
Nov 22, 2021
Copy link
Copy Markdown
Member
|
@nodejs/fs |
Sorry, something went wrong.
This comment has been minimized.
aduh95
reviewed
Nov 22, 2021
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can you please add a test case where length is 0?
Sorry, something went wrong.
Comment thread
test/parallel/test-fs-promises-file-handle-read.js
Outdated
Comment thread
test/parallel/test-fs-promises-file-handle-read.js
Outdated
45 tasks
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Nov 23, 2021
This comment has been minimized.
This was referenced Nov 24, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
33 tasks
lpinca
approved these changes
Nov 26, 2021
27 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Currently, `length` in an options object is ignored. PR-URL: #40906 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Currently, `length` in an options object is ignored. PR-URL: #40906 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Currently, `length` in an options object is ignored. PR-URL: #40906 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Currently, `length` in an options object is ignored. PR-URL: #40906 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, calling read() with an options object always uses buffer.byteLength, ignoring length in the object.
First time opening a PR here, please let me know if anything doesn't conform to the guidelines.