tools: only validate first commit message of a PR - #40740
Merged
aduh95 merged 2 commits intoNov 12, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
targos
approved these changes
Nov 6, 2021
lpinca
approved these changes
Nov 6, 2021
Comment thread
.github/workflows/commit-lint.yml
Outdated
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/40740 ✔ Done loading data for nodejs/node/pull/40740 ----------------------------------- PR info ------------------------------------ Title tools: only validate first commit message of a PR (#40740) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:lint-only-first-commit-message -> nodejs:master Labels meta Commits 2 - tools: only validate first commit message of a PR - Update .github/workflows/commit-lint.yml Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/40740 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40740 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Update .github/workflows/commit-lint.yml ℹ This PR was created on Sat, 06 Nov 2021 09:23:07 GMT ✔ Approvals: 2 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40740#pullrequestreview-799430947 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40740#pullrequestreview-799469206 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1436426233 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/40740 ✔ Done loading data for nodejs/node/pull/40740 ----------------------------------- PR info ------------------------------------ Title tools: only validate first commit message of a PR (#40740) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:lint-only-first-commit-message -> nodejs:master Labels meta, commit-queue-squash Commits 2 - tools: only validate first commit message of a PR - Update .github/workflows/commit-lint.yml Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/40740 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40740 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Update .github/workflows/commit-lint.yml ℹ This PR was created on Sat, 06 Nov 2021 09:23:07 GMT ✔ Approvals: 2 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40740#pullrequestreview-799430947 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40740#pullrequestreview-799469206 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1454898010 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
PR-URL: #40740 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40740 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40740 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit-lint job was introduced to encourage contributors to generate PRs that would be landable using the CQ IIRC.
Now that #40577 has introduced commit-queue-squash mechanism, having the commint-lint job lint all commit message defeats its purpose as it won't let the CQ land a PR if any of its commit do not conform to our guidelines – even though in the case of a squash, only the first commit message matters.
I'm suggesting validating only the first commit message, and discarding follow up commits in the validation.
I have thought about making the job label-aware, and if the PR has a commit-queue-rebase label validate all the commits: that might be more effort than what's worth, the CQ will refuse to land a PR if the commit message do not pass the validation anyway.