tools: abort CQ session when landing several commits - #40577
Merged
aduh95 merged 3 commits intoNov 1, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: nodejs#40436 Refs: nodejs/node-core-utils#572
Mesteery
reviewed
Oct 23, 2021
aduh95
added a commit
to nodejs/node-auto-test
that referenced
this pull request
Oct 30, 2021
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: nodejs/node#40436 Refs: nodejs/node-core-utils#572 PR-URL: nodejs/node#40577
aduh95
added a commit
to nodejs/node-auto-test
that referenced
this pull request
Oct 30, 2021
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: nodejs/node#40436 Refs: nodejs/node-core-utils#572 PR-URL: nodejs/node#40577
targos
approved these changes
Oct 31, 2021
Comment thread
doc/guides/commit-queue.md
Outdated
Trott
approved these changes
Nov 1, 2021
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: #40436 Refs: nodejs/node-core-utils#572 PR-URL: #40577 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
Most PRs are meant to be squashed in one commit when landing. If the collaborator hasn't been using `fixup!` commits, the CQ lands the PR as several commits. This change makes the CQ abort by default when attempting to land several commits, unless there's another label added to the PR to force squashing or landing as several commits. Fixes: #40436 Refs: nodejs/node-core-utils#572 PR-URL: #40577 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most PRs are meant to be squashed in one commit when landing. If the
collaborator hasn't been using fixup! commits, the CQ will land the PR
as several commits. This change makes the CQ abort by default
when attempting to land several commits, unless there's another
label added to the PR to force squashing or landing as several commits.
Fixes: #40436
Blocked on nodejs/node-core-utils#572