build: ignore unrelated workflow changes in slow Actions tests - #40928
Merged
nodejs-github-bot merged 1 commit intoNov 27, 2021
Merged
build: ignore unrelated workflow changes in slow Actions tests#40928nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
aduh95
approved these changes
Nov 23, 2021
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
tbh we could do that for all the workflow files
Sorry, something went wrong.
richardlau
reviewed
Nov 23, 2021
Comment thread
.github/workflows/test-asan.yml
Outdated
tniessen
approved these changes
Nov 23, 2021
tniessen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM modulo @richardlau's comment
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Perhaps all the test-* files. We don't want to do it for the one that lints the commit message, for example. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Refactored to use paths instead of paths-ignore. Did I do it right? |
Sorry, something went wrong.
Trott
force-pushed
the
skip-macos
branch
2 times, most recently
from
45dbbce to
5b94831
Compare
November 23, 2021 03:53
Copy link
Copy Markdown
Member
Author
|
Per suggestion from @aduh95, I've also put this into test-linux.yml. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'm concerned that the way I did this means that everything matches except the last negation. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
OK, I think what I have now should work. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I think this is my fault. See #40934 |
Sorry, something went wrong.
aduh95
reviewed
Nov 23, 2021
Comment thread
.github/workflows/test-linux.yml
Outdated
Mesteery
reviewed
Nov 23, 2021
Comment thread
.github/workflows/test-asan.yml
Outdated
Copy link
Copy Markdown
Member
Author
|
OK, i think this will work and addresses all comments. Re-reviews welcome! |
Sorry, something went wrong.
test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR.
aduh95
approved these changes
Nov 26, 2021
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Nov 27, 2021
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: nodejs#40928
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 30, 2021
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR. PR-URL: #40928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR. PR-URL: #40928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
test-asan and test-macos are very slow and tend to get backed up. While I'm literally waiting hours right now for test-macos to finish so I can land a PR, I'm opening this pull request to have it be skipped when things other than its own workflow file are the only changes in the PR. PR-URL: #40928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Changes in the workflow files never affect the node binary, running build tasks seems unnecessary. Refs: #40928 PR-URL: #40990 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-asan and test-macos are very slow and tend to get backed up. While
I'm literally waiting hours right now for test-macos to finish so I can
land a PR, I'm opening this pull request to have it be skipped when
things other than its own workflow file are the only changes in the PR.