tools: update gyp-next to v0.10.1 - #40934
Merged
nodejs-github-bot merged 1 commit intoNov 26, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think it works.
|
Sorry, something went wrong.
targos
added a commit
to nodejs/gyp-next
that referenced
this pull request
Nov 23, 2021
It's already like this in the msvs and ninja generators. Refs: nodejs/node#40934
45 tasks
targos
added a commit
to nodejs/gyp-next
that referenced
this pull request
Nov 24, 2021
…133) It's already like this in the msvs and ninja generators. Refs: nodejs/node#40934
targos
force-pushed
the
gyp-make-toolset
branch
from
24bc4df to
c7a1bdf
Compare
November 24, 2021 10:37
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Nov 24, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
38 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
BethGriggs
approved these changes
Nov 25, 2021
Qard
approved these changes
Nov 25, 2021
33 tasks
Trott
approved these changes
Nov 26, 2021
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Rubber stamp LGTM
Sorry, something went wrong.
targos
added a commit
that referenced
this pull request
Nov 26, 2021
PR-URL: #40934 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Nov 27, 2021
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40934 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40934 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the regression in compilation times after #40488
I'll upstream to gyp-next if it works.