FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: fix non readable Duplex readableAborted by ronag · Pull Request #40801 · nodejs/node · GitHub

/ node Public

stream: fix non readable Duplex readableAborted - #40801

Closed
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:readable-aborted
ConversationCommits (4)ChecksFiles changed
Closed

stream: fix non readable Duplex readableAborted#40801
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:readable-aborted

Conversation

ronag commented Nov 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #40800

ronag added the stream Issues and PRs related to the stream subsystem. label Nov 13, 2021
ronag requested a review from mcollina November 13, 2021 13:04

ronag commented Nov 13, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 13, 2021
ronag added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 13, 2021
ronag requested a review from lpinca November 13, 2021 16:26
ronag removed the needs-ci PRs that need a full CI run. label Nov 13, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2021

nodejs-github-bot commented Nov 13, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40866/

mcollina approved these changes Nov 13, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

This was referenced Nov 14, 2021
Open
Open

ronag commented Nov 15, 2021

Copy link
Copy Markdown
Member Author

Landed in 640bfb8

ronag closed this Nov 15, 2021
ronag added a commit that referenced this pull request Nov 15, 2021
stream: fix non readable Duplex readableAborted
640bfb8 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Nov 16, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
stream: fix non readable Duplex readableAborted
7d127d2 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
stream: fix non readable Duplex readableAborted
218ada9 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
stream: fix non readable Duplex readableAborted
55c9349 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes
juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

non readable Duplex should not be readableAborted

6 participants

Back | FazBrowse Home | New Git URL