FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: allow calling callback before promise by ronag · Pull Request #40772 · nodejs/node · GitHub

/ node Public

stream: allow calling callback before promise - #40772

Closed
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:then-callback
ConversationCommits (4)ChecksFiles changed
Closed

stream: allow calling callback before promise#40772
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:then-callback

Conversation

ronag commented Nov 10, 2021

Copy link
Copy Markdown
Member

Refs: #39535

ronag commented Nov 10, 2021

Copy link
Copy Markdown
Member Author

@nodejs/streams @mcollina wdyt?

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 10, 2021
mcollina reviewed Nov 10, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This needs a test

mcollina commented Nov 10, 2021

Copy link
Copy Markdown
Member

Ok for me!

ronag marked this pull request as ready for review November 10, 2021 08:41
ronag requested a review from mcollina November 10, 2021 08:41
ronag added request-ci Add this label to start a Jenkins CI on a PR. stream Issues and PRs related to the stream subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Nov 10, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021

This comment has been minimized.

Sign in to view

paulrutter commented Nov 10, 2021

Copy link
Copy Markdown

Will this land in the next Node16 release? @ronag

benjamingr commented Nov 10, 2021

Copy link
Copy Markdown
Member

I don't understand the impact well enough to review

mcollina approved these changes Nov 10, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021

This comment has been minimized.

Sign in to view
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2021

nodejs-github-bot commented Nov 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40817/

VoltrexKeyva mentioned this pull request Nov 10, 2021
Merged
github-actions Bot mentioned this pull request Nov 11, 2021
Open
31 tasks

paulrutter commented Nov 11, 2021

Copy link
Copy Markdown

This issue is important for knowing if we can proceed with Node16 on the short term.
Do you think this will land in next Node16 release @ronag ?

mcollina commented Nov 11, 2021

Copy link
Copy Markdown
Member

Do you think this will land in next Node16 release @ronag ?

This needs to be released in v17 first and after two weeks it could land on v16. I think the timeline is 4-8 weeks.

ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 12, 2021

nodejs-github-bot commented Nov 12, 2021 •
edited by ronag
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40845/ ✅

github-actions Bot mentioned this pull request Nov 13, 2021
Open
31 tasks
ronag requested review from jasnell and lpinca November 13, 2021 13:48
ronag added the review wanted PRs that need reviews. label Nov 13, 2021
mcollina approved these changes Nov 13, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

github-actions Bot mentioned this pull request Nov 14, 2021
Open
41 tasks
ronag added a commit that referenced this pull request Nov 14, 2021
stream: allow calling callback before promise
afe460e 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ronag commented Nov 14, 2021

Copy link
Copy Markdown
Member Author

Landed in afe460e

ronag closed this Nov 14, 2021
ronag added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v16.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. review wanted PRs that need reviews. labels Nov 14, 2021
GulajavaMinistudio mentioned this pull request Nov 14, 2021
Merged
This was referenced Nov 15, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
stream: allow calling callback before promise
7c4f9a3 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
targos mentioned this pull request Nov 26, 2021
Merged
paulrutter mentioned this pull request Dec 28, 2021
Closed
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
stream: allow calling callback before promise
6275b07 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
stream: allow calling callback before promise
1f722a1 
Refs: #39535

PR-URL: #40772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL