FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: align module resolve algorithm with implementation by Ayase-252 · Pull Request #38837 · nodejs/node · GitHub

/ node Public

doc: align module resolve algorithm with implementation - #38837

Merged
aduh95 merged 3 commits into
nodejs:masterfrom
Ayase-252:fix/module-doc-38128
Dec 14, 2021
ConversationCommits (3)ChecksFiles changed
Merged

doc: align module resolve algorithm with implementation#38837
aduh95 merged 3 commits into
nodejs:masterfrom
Ayase-252:fix/module-doc-38128

Conversation

Ayase-252 commented May 29, 2021

Copy link
Copy Markdown
Member

In docs, it reads like GLOBAL_FOLDERS takes precedence over node_module, but in implementation, GLOBAL_FOLDERS is appended to the last of paths to resolve. It should take lowest priority.

node/lib/internal/modules/cjs/loader.js

Line 678 in f1cbaea

paths = ArrayPrototypeConcat(parent.paths, paths);

Fixes: #38128

github-actions Bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels May 29, 2021
bl-ue reviewed May 29, 2021
View reviewed changes
Comment thread doc/api/modules.md Outdated

aduh95 commented May 29, 2021

Copy link
Copy Markdown
Contributor

@nodejs/modules

guybedford reviewed May 29, 2021
View reviewed changes
Comment thread doc/api/modules.md Outdated
fixup: take advice from review
f77fe64 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Christopher Beeson <christopher@bl-ue.com>
ljharb reviewed May 31, 2021
View reviewed changes
Comment thread doc/api/modules.md Outdated
fixup: unify usage
82b1d1f 
Co-authored-by: Jordan Harband <ljharb@gmail.com>

Ayase-252 commented May 31, 2021

Copy link
Copy Markdown
Member Author

It seems that GH action build-windows is quite unstable?

kongmoumou commented Dec 14, 2021

Copy link
Copy Markdown

When will this PR be merged 😂

aduh95 merged commit ea977fc into nodejs:master Dec 14, 2021

aduh95 commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

Landed in ea977fc

danielleadams pushed a commit that referenced this pull request Dec 16, 2021
doc: align module resolve algorithm with implementation
af2f2ad 
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams mentioned this pull request Dec 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Dec 17, 2021
doc: align module resolve algorithm with implementation
1274a25 
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
doc: align module resolve algorithm with implementation
e094f82 
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
doc: align module resolve algorithm with implementation
f4f9fcb 
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
doc: align module resolve algorithm with implementation
ac025f1 
Fixes: #38128

PR-URL: #38837
Reviewed-By: Guy Bedford <guybedford@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
chirsz-ever added a commit to chirsz-ever/node that referenced this pull request Mar 29, 2025
doc: fix pseudo code in modules.md
01a78d4 
This problem was introduced in PR nodejs#38837.
chirsz-ever mentioned this pull request Mar 29, 2025
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 8, 2025
doc: fix pseudo code in modules.md
6225189 
This problem was introduced in PR #38837.

PR-URL: #57677
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 10, 2025
doc: fix pseudo code in modules.md
f72880d 
This problem was introduced in PR #38837.

PR-URL: #57677
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 11, 2025
doc: fix pseudo code in modules.md
5cec2b1 
This problem was introduced in PR #38837.

PR-URL: #57677
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 13, 2025
doc: fix pseudo code in modules.md
6283bb5 
This problem was introduced in PR #38837.

PR-URL: #57677
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
doc: fix pseudo code in modules.md
a7046f8 
This problem was introduced in PR #38837.

PR-URL: #57677
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
doc: fix pseudo code in modules.md
df46ffd 
This problem was introduced in PR #38837.

PR-URL: #57677
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
doc: fix pseudo code in modules.md
b5db02f 
This problem was introduced in PR #38837.

PR-URL: #57677
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb left review comments
guybedford guybedford approved these changes
+2 more reviewers
kongmoumou kongmoumou left review comments
bl-ue bl-ue left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NODE_PATH documentation appears to be incorrect

6 participants

Back | FazBrowse Home | New Git URL