| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@targos Yes, I like your suggestions better than the auto-fixed changes. Adopted. Thanks! |
Sorry, something went wrong.
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/41109 ✔ Done loading data for nodejs/node/pull/41109 ----------------------------------- PR info ------------------------------------ Title tools: enable JSDoc check-alignment lint rule (#41109) Author Rich Trott (@Trott) Branch Trott:jsdoc-check-alignment -> nodejs:master Labels tools, needs-ci, commit-queue-rebase Commits 2 - doc,lib,tools: align multiline comments - tools: enable JSDoc check-alignment lint rule Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41109 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41109 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 07 Dec 2021 14:38:30 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825370225 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825595191 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825647060 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41109#pullrequestreview-825760708 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-12-07T23:31:07Z: https://ci.nodejs.org/job/node-test-pull-request/41413/ - Querying data for job/node-test-pull-request/41413/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41109 From https://github.com/nodejs/node * branch refs/pull/41109/merge -> FETCH_HEAD ✔ Fetched commits as 3697587c31c7..7347e2cfd83b -------------------------------------------------------------------------------- [master a458871855] doc,lib,tools: align multiline comments Author: Rich Trott Date: Tue Dec 7 06:35:08 2021 -0800 4 files changed, 7 insertions(+), 7 deletions(-) [master 140daca3a6] tools: enable JSDoc check-alignment lint rule Author: Rich Trott Date: Tue Dec 7 06:35:45 2021 -0800 1 file changed, 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)
Temporary files removed.
|
Sorry, something went wrong.
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: nodejs#41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: #41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: #41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
These changes are in preparation for enabling a JSDoc lint rule. PR-URL: #41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
| Back | FazBrowse Home | New Git URL |
This affects more than just JSDoc comments, but I'm OK with that.