FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: enable JSDoc check-alignment lint rule by Trott · Pull Request #41109 · nodejs/node · GitHub

/ node Public

tools: enable JSDoc check-alignment lint rule - #41109

Merged
Trott merged 2 commits into
nodejs:masterfrom
Trott:jsdoc-check-alignment
Dec 9, 2021
Merged

tools: enable JSDoc check-alignment lint rule#41109
Trott merged 2 commits into
nodejs:masterfrom
Trott:jsdoc-check-alignment

Conversation

Trott commented Dec 7, 2021
edited
Loading

Copy link
Copy Markdown
Member

This affects more than just JSDoc comments, but I'm OK with that.

Trott added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Dec 7, 2021
nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Dec 7, 2021
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2021

This comment has been minimized.

Comment thread doc/api/tls.md Outdated
Comment thread doc/api/url.md Outdated
Comment thread doc/api/url.md Outdated
Trott force-pushed the jsdoc-check-alignment branch from d364d56 to 7347e2c Compare December 7, 2021 17:34

This comment has been minimized.

Trott commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

@targos Yes, I like your suggestions better than the auto-fixed changes. Adopted. Thanks!

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2021
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 9, 2021

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41109
✔  Done loading data for nodejs/node/pull/41109
----------------------------------- PR info ------------------------------------
Title      tools: enable JSDoc check-alignment lint rule (#41109)
Author     Rich Trott  (@Trott)
Branch     Trott:jsdoc-check-alignment -> nodejs:master
Labels     tools, needs-ci, commit-queue-rebase
Commits    2
 - doc,lib,tools: align multiline comments
 - tools: enable JSDoc check-alignment lint rule
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41109
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41109
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 07 Dec 2021 14:38:30 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825370225
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825595191
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/41109#pullrequestreview-825647060
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41109#pullrequestreview-825760708
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-12-07T23:31:07Z: https://ci.nodejs.org/job/node-test-pull-request/41413/
- Querying data for job/node-test-pull-request/41413/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 41109
From https://github.com/nodejs/node
 * branch                  refs/pull/41109/merge -> FETCH_HEAD
✔  Fetched commits as 3697587c31c7..7347e2cfd83b
--------------------------------------------------------------------------------
[master a458871855] doc,lib,tools: align multiline comments
 Author: Rich Trott 
 Date: Tue Dec 7 06:35:08 2021 -0800
 4 files changed, 7 insertions(+), 7 deletions(-)
[master 140daca3a6] tools: enable JSDoc check-alignment lint rule
 Author: Rich Trott 
 Date: Tue Dec 7 06:35:45 2021 -0800
 1 file changed, 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc,lib,tools: align multiline comments

These changes are in preparation for enabling a JSDoc lint rule.

PR-URL: #41109
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 763cff735b] doc,lib,tools: align multiline comments
Author: Rich Trott rtrott@gmail.com
Date: Tue Dec 7 06:35:08 2021 -0800
4 files changed, 7 insertions(+), 7 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: enable JSDoc check-alignment lint rule

PR-URL: #41109
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 54dc36e6fc] tools: enable JSDoc check-alignment lint rule
Author: Rich Trott rtrott@gmail.com
Date: Tue Dec 7 06:35:45 2021 -0800
1 file changed, 1 deletion(-)

Successfully rebased and updated refs/heads/master.

✔ 763cff735b68e9764f451363f41593e78c2dc371
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✔ 54dc36e6fc44e96c48b6a1cfaf690c02d2cd5034
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

The following commits are ready to be pushed to origin/master

  • 763cff735b doc,lib,tools: align multiline comments
  • 54dc36e6fc tools: enable JSDoc check-alignment lint rule

Temporary files removed.
To finish landing:

  1. Run:
    git push origin master
  2. Post "Landed in 3697587c31c7...54dc36e6fc44" in tools: enable JSDoc check-alignment lint rule #41109
    gh pr comment 41109 --body "Landed in 3697587c31c7...54dc36e6fc44"
    gh pr close 41109
    fatal: could not read Username for 'https://github.com': No such device or address
https://github.com/nodejs/node/actions/runs/1559626012

Trott added 2 commits December 9, 2021 08:31
These changes are in preparation for enabling a JSDoc lint rule.

PR-URL: nodejs#41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott force-pushed the jsdoc-check-alignment branch from 7347e2c to ecf4114 Compare December 9, 2021 16:32

Trott commented Dec 9, 2021

Copy link
Copy Markdown
Member Author

Landed in 3697587...ecf4114

Trott merged commit ecf4114 into nodejs:master Dec 9, 2021
Trott deleted the jsdoc-check-alignment branch December 9, 2021 16:32
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
These changes are in preparation for enabling a JSDoc lint rule.

PR-URL: #41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
PR-URL: #41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
These changes are in preparation for enabling a JSDoc lint rule.

PR-URL: #41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
These changes are in preparation for enabling a JSDoc lint rule.

PR-URL: #41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL