FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip ESLint tests if no Intl by Trott · Pull Request #41105 · nodejs/node · GitHub

/ node Public

test: skip ESLint tests if no Intl - #41105

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:unicode-whoops
Dec 7, 2021
ConversationCommits (1)ChecksFiles changed
Merged

test: skip ESLint tests if no Intl#41105
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:unicode-whoops

Conversation

Trott commented Dec 7, 2021

Copy link
Copy Markdown
Member

ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

test: skip ESLint tests if no Intl
07f0bb1 
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: nodejs#41102
Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 7, 2021

Trott commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

Seeking fast-tracking because this fixes CI.

github-actions Bot commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 7, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2021

nodejs-github-bot commented Dec 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41379/

Trott mentioned this pull request Dec 7, 2021
Closed
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 7, 2021

nodejs-github-bot commented Dec 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41381/

richardlau requested a review from lpinca December 7, 2021 07:27

nodejs-github-bot commented Dec 7, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41382/

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2021
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 7, 2021
nodejs-github-bot merged commit e60801a into nodejs:master Dec 7, 2021

nodejs-github-bot commented Dec 7, 2021

Copy link
Copy Markdown
Collaborator

Landed in e60801a

This was referenced Dec 8, 2021
Open
Open
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
test: skip ESLint tests if no Intl
1f6a9c3 
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
test: skip ESLint tests if no Intl
4046f56 
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
test: skip ESLint tests if no Intl
84f47b8 
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
test: skip ESLint tests if no Intl
28c52f6 
ESLint dependency now requires Intl because it uses regexp unicode
character properties.

Fixes: #41102

PR-URL: #41105
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams mentioned this pull request Feb 1, 2022
Merged
Trott deleted the unicode-whoops branch September 25, 2022 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes
lpinca Awaiting requested review from lpinca
+2 more reviewers
targos targos approved these changes
DerekNonGeneric DerekNonGeneric approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken CI

7 participants

Back | FazBrowse Home | New Git URL