stream: remove whatwg streams experimental warning - #40971
Merged
nodejs-github-bot merged 1 commit intoDec 1, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The API is still experimental, but the warning isn't necessary any longer Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
remove-web-streams-experimental-warning
branch
from
a775b03 to
88617b7
Compare
November 25, 2021 19:24
benjamingr
approved these changes
Nov 25, 2021
Flarna
approved these changes
Nov 25, 2021
ronag
approved these changes
Nov 26, 2021
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/40971 ✔ Done loading data for nodejs/node/pull/40971 ----------------------------------- PR info ------------------------------------ Title stream: remove whatwg streams experimental warning (#40971) Author James M Snell (@jasnell) Branch jasnell:remove-web-streams-experimental-warning -> nodejs:master Labels stream, needs-ci Commits 1 - stream: remove whatwg streams experimental warning Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/40971 Refs: https://github.com/nodejs/node/issues/40950 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Gerhard Stöbich Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40971 Refs: https://github.com/nodejs/node/issues/40950 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Gerhard Stöbich Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 25 Nov 2021 18:54:40 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40971#pullrequestreview-816291609 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/40971#pullrequestreview-816306633 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/40971#pullrequestreview-816684520 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1522493978 |
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Dec 3, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
The API is still experimental, but the warning isn't necessary any longer Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40971 Refs: #40950 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
The API is still experimental, but the warning isn't necessary any longer Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40971 Refs: #40950 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
The API is still experimental, but the warning isn't necessary any longer Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #40971 Refs: #40950 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API is still experimental, but the warning isn't necessary any longer
Refs: #40950