FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools,lib: enable jsdoc/require-returns-type ESLint rule by Trott · Pull Request #41130 · nodejs/node · GitHub

/ node Public

tools,lib: enable jsdoc/require-returns-type ESLint rule - #41130

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:require-returns-type
Closed

tools,lib: enable jsdoc/require-returns-type ESLint rule#41130
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:require-returns-type

Conversation

Trott commented Dec 9, 2021

Copy link
Copy Markdown
Member

No description provided.

Add types to @returns JSDoc annotations where the type is missing.
Trott added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Dec 9, 2021
nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 9, 2021

targos commented Dec 10, 2021

Copy link
Copy Markdown
Member

s/reutrns/returns/

Trott force-pushed the require-returns-type branch from 2d21012 to 0ae51d3 Compare December 10, 2021 13:00
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2021
Trott changed the title tools,lib: enable jsdoc/require-reutrns-type ESLint rule tools,lib: enable jsdoc/require-returns-type ESLint rule Dec 10, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2021

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 11, 2021
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2021
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2021

Copy link
Copy Markdown
Collaborator

Landed in c2ff69d...12e3c74

nodejs-github-bot pushed a commit that referenced this pull request Dec 12, 2021
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit that referenced this pull request Dec 12, 2021
PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott deleted the require-returns-type branch December 12, 2021 12:43
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Add types to @returns JSDoc annotations where the type is missing.

PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41130
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL