[v16.x] Fix JS linting warnings and errors - #41805
Closed
danielleadams wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
reviewed
Feb 1, 2022
Comment thread
lib/internal/blob.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| * @returns {any} | |
| * @constructs {Blob} |
(same commit for other @returns changes)
Maybe the commit can be cherry-picked without trouble now?
Sorry, something went wrong.
Comment thread
lib/internal/bootstrap/node.js
Outdated
targos
reviewed
Feb 1, 2022
Comment thread
lib/readline.js
Outdated
danielleadams
force-pushed
the
da/fix-js-lint
branch
from
75896f7 to
88f8e97
Compare
February 1, 2022 12:26
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @danielleadams. Please 👍 to approve. |
Sorry, something went wrong.
danielleadams
force-pushed
the
da/fix-js-lint
branch
from
88f8e97 to
cdfbef2
Compare
February 1, 2022 12:29
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
targos
approved these changes
Feb 1, 2022
danielleadams
force-pushed
the
da/fix-js-lint
branch
from
cdfbef2 to
58f1200
Compare
February 1, 2022 13:01
This was referenced Feb 2, 2022
This was referenced Feb 4, 2022
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/collaborators anyone around to give a 👍🏼 ? |
Sorry, something went wrong.
aduh95
approved these changes
Feb 5, 2022
Trott
approved these changes
Feb 5, 2022
Mesteery
approved these changes
Feb 5, 2022
danielleadams
added a commit
that referenced
this pull request
Feb 5, 2022
PR-URL: #41805 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
added a commit
that referenced
this pull request
Feb 5, 2022
PR-URL: #41805 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
27 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating #41804, I ran into some linting exceptions. I'm not sure if any of these are fixed in master, but for the purposes of getting the release out, I wanted to fix them in v16.x-staging since they were easy changes.