FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: add mising initialization by mhdawson · Pull Request #40555 · nodejs/node · GitHub

/ node Public

http: add mising initialization - #40555

Closed
mhdawson wants to merge 3 commits into
nodejs:masterfrom
mhdawson:coverity-4
ConversationCommits (3)ChecksFiles changed
Closed

http: add mising initialization#40555
mhdawson wants to merge 3 commits into
nodejs:masterfrom
mhdawson:coverity-4

Conversation

mhdawson commented Oct 21, 2021

Copy link
Copy Markdown
Member

Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson mdawson@devrus.com

http: add mising initialization
bb77126 
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson requested a review from jasnell October 21, 2021 20:58
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 21, 2021

mhdawson commented Oct 21, 2021

Copy link
Copy Markdown
Member Author

@jasnell I think moving the env_ makes sense but hoping you can easily confirm/correct.

addaleax approved these changes Oct 22, 2021
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jasnell I think moving the env_ makes sense but hoping you can easily confirm/correct.

@mhdawson Moving a pointer doesn’t do anything (except maybe look odd).

fixup: remove unecessary move
dc146f9 
Signed-off-by: Michael Dawson <mdawson@devrus.com>

mhdawson commented Oct 25, 2021

Copy link
Copy Markdown
Member Author

@addaleax thanks, pushed a commit to remove the move.

nodejs-github-bot commented Oct 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40519/

github-actions Bot mentioned this pull request Oct 28, 2021
Open
30 tasks

nodejs-github-bot commented Oct 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40540/

This was referenced Oct 29, 2021
Open
Open
Open
Open

nodejs-github-bot commented Nov 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40656/

tniessen commented Nov 2, 2021

Copy link
Copy Markdown
Member

Nit: typo in commit message

github-actions Bot mentioned this pull request Nov 3, 2021
Open
42 tasks

nodejs-github-bot commented Nov 3, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40688/

This was referenced Nov 4, 2021
Open
Open
Open
Open
Open

nodejs-github-bot commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40800/

nodejs-github-bot commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40804/

github-actions Bot mentioned this pull request Nov 10, 2021
Open
26 tasks
This was referenced Nov 11, 2021
Open
Open
mhdawson added a commit that referenced this pull request Nov 12, 2021
http: add missing initialization
055a38b 
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

mhdawson commented Nov 12, 2021

Copy link
Copy Markdown
Member Author

Landed in 055a38b4c7db64ab1461cd44b7605d5b020ab382

mhdawson closed this Nov 12, 2021
This was referenced Nov 13, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
http: add missing initialization
bddb4c6 
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
http: add missing initialization
2b7197d 
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
http: add missing initialization
86bbb42 
Add missing initialization reported by coverity scan.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40555
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
tniessen tniessen approved these changes
jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL