build: use gh cli in workflows file - #40985
Conversation
Sorry, something went wrong.
|
Waiting the next release of GitHub CLI for cli/cli@1eb790c. |
Sorry, something went wrong.
aduh95
left a comment
There was a problem hiding this comment.
You forgot to filter the label it seems.
Sorry, something went wrong.
Ah indeed, thank you! |
Sorry, something went wrong.
|
Is it both blocked and author ready? That seems contradictory. |
Sorry, something went wrong.
For me it does not seem contradictory, there is also #38889 for example. Description of author ready:
|
Sorry, something went wrong.
|
GitHub CLI 2.3.0 is now available in GitHub Actions runners. |
Sorry, something went wrong.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Is it at all possible that this broke the label-commenting workflow? Or maybe it was already broken? (Or maybe I don't understand how it's supposed to work?) After this landed, I labeled #14086 with stalled but no comment has been posted there yet from the workflow. |
Sorry, something went wrong.
|
https://github.com/nodejs/node/runs/4525021875?check_suite_focus=true Run gh pr comment "$NUMBER" --repo nodejs/node --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
gh pr comment "$NUMBER" --repo nodejs/node --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
shell: /usr/bin/bash -e {0}
env:
NUMBER: 14086
GITHUB_TOKEN: ***
GraphQL: Could not resolve to a PullRequest with the number of 14086. (repository.pullRequest)
Error: Process completed with exit code 1.
|
Sorry, something went wrong.
|
Ah, sorry, commenting on PRs and issues only works with gh issue comment.
|
Sorry, something went wrong.
Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
I'm not sure if this wasn't the case before this PR, but it looks like Commit Queue is failing when there are no PRs for it to land. I would expect it to succeed in that case. Example: https://github.com/nodejs/node/runs/4540327006?check_suite_focus=true Because the last command is a gh command, I'm guessing this PR might have had something to do with it, but I could be wrong. |
Sorry, something went wrong.
PR-URL: #40985 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #40985 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #40985 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #40985 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #40985 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: #40985 (comment) PR-URL: #41176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Refs: #40985 (comment) PR-URL: #41193 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
No description provided.