tools: ping TSC members identified as inactive by Trott · Pull Request #40915 · nodejs/node · GitHub

When detecting TSC members as inactive, @-mention them in the pull
request that moves them to emeritus. This notifies them in case the pull
request is in error.

If we want to 100% make sure this works, we can fast-track it, close #40908, and let this open a PR.

This lgtm, but it was mostly the next part of the message that I was interested in automating:

codebytere last attended a TSC meeting in September 2020. gabrielschulhof last attended a TSC meeting in May 2021. Neither have participated in recent votes.

This lgtm, but it was mostly the next part of the message that I was interested in automating:

codebytere last attended a TSC meeting in September 2020. gabrielschulhof last attended a TSC meeting in May 2021. Neither have participated in recent votes.

OK, I think this does something like that now. (I haven't tested it via an Action yet, but will run it when it lands and revise if necessary.)

When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error.

Landed in f7ac6ba

https://github.com/nodejs/node/runs/4315947355?check_suite_focus=true

Run gr2m/create-or-update-pull-request-action@v1
with:
    author: Node.js GitHub Bot <github-bot@iojs.org>
    branch: actions/inactive-tsc
    body: This PR was generated by tools/find-inactive-tsc.yml.
  
  @nodejs/tsc "@codebytere @gabrielschulhof"
  
  "Since 3 months ago, codebytere attended 0 out of 10 meetings and voted in 0 of 2 votes. Since 3 months ago, gabrielschulhof attended 0 out of 10 meetings and voted in 0 of 2 votes."
  
    commit-message: meta: move one or more TSC members to emeritus
    labels: meta
    title: meta: move one or more TSC members to emeritus
  env:
    NODE_VERSION: lts/*
    INACTIVE_TSC_HANDLES: "@codebytere @gabrielschulhof"
    DETAILS_FOR_COMMIT_BODY: "Since 3 months ago, codebytere attended 0 out of 10 meetings and voted in 0 of 2 votes. Since 3 months ago, gabrielschulhof attended 0 out of 10 meetings and voted in 0 of 2 votes."

The only nit would be to get rid of the " (maybe using fromJSON? not sure); other than that, LGTM.

The only nit would be to get rid of the " (maybe using fromJSON? not sure); other than that, LGTM.

I wonder if spaces aren't a problem in single-line GITHUB_ENV entries and we can just remove the quotation marks there.

I don't know for GITHUB_ENV, but when using ::set-output quotes are not needed: https://github.com/nodejs/node/pull/40845/files#diff-f9aa500b86b242f58f185509ad323b3526cf5effc683df4b5cb4d78df4108c5fR15-R16

And if all else fails, we can use the multi-line HEREDOC format they support which doesn't require quotation marks or other punctuation around spaces.

(Testing now on my fork.)

Yup, leaving out the quotation marks worked. https://github.com/Trott/io.js/runs/4318829465?check_suite_focus=true (The failure is because I didn't set a needed token on my fork.)

PR coming momentarily.

Refs: nodejs#40915 (comment)

Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error. PR-URL: #40915 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>

Refs: #40915 (comment) PR-URL: #40963 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 21, 2021

Trott requested a review from targos November 21, 2021 20:04

Mesteery reviewed Nov 21, 2021

View reviewed changes

Comment thread .github/workflows/find-inactive-tsc.yml Outdated

BridgeAR approved these changes Nov 22, 2021

View reviewed changes

Trott force-pushed the tsc-ping branch from d546290 to 25d0d31 Compare November 24, 2021 05:54

Trott added 2 commits November 23, 2021 22:22

tools: ping TSC members identified as inactive

b5cebc7

When detecting TSC members as inactive, @-mention them in the pull request that moves them to emeritus. This notifies them in case the pull request is in error.

fixup! tools: ping TSC members identified as inactive

344c45d

Trott force-pushed the tsc-ping branch from afecf97 to 344c45d Compare November 24, 2021 06:22

Mesteery reviewed Nov 24, 2021

View reviewed changes

Comment thread .github/workflows/find-inactive-tsc.yml Outdated

fixup! fixup! tools: ping TSC members identified as inactive

4131953

jasnell approved these changes Nov 24, 2021

View reviewed changes

targos approved these changes Nov 24, 2021

View reviewed changes

richardlau approved these changes Nov 24, 2021

View reviewed changes

BethGriggs approved these changes Nov 24, 2021

View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2021

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2021

nodejs-github-bot merged commit f7ac6ba into nodejs:master Nov 24, 2021

Trott deleted the tsc-ping branch November 24, 2021 18:34

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2021

build: remove extraneous quotation marks from commit body

fd39b2a

Refs: nodejs#40915 (comment)

Trott mentioned this pull request Nov 25, 2021

build: remove extraneous quotation marks from commit body #40963

Merged

targos mentioned this pull request Nov 26, 2021

v17.2.0 release proposal #40983

Merged

danielleadams mentioned this pull request Feb 1, 2022

v16.14.0 proposal #41804

Merged

tools: ping TSC members identified as inactive by Trott · Pull Request #40915 · nodejs/node · GitHub

Uh oh!

Uh oh!

tools: ping TSC members identified as inactive - #40915

tools: ping TSC members identified as inactive#40915
nodejs-github-bot merged 3 commits into
nodejs:masterfrom
Trott:tsc-ping

Trott commented Nov 21, 2021

Uh oh!

Trott commented Nov 21, 2021

Uh oh!

Uh oh!

targos commented Nov 22, 2021

Uh oh!

Trott commented Nov 24, 2021

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 24, 2021

Uh oh!

aduh95 commented Nov 25, 2021 •
edited
Loading

Uh oh!

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

aduh95 commented Nov 25, 2021

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tools: ping TSC members identified as inactive by Trott · Pull Request #40915 · nodejs/node · GitHub

Uh oh!

Uh oh!

tools: ping TSC members identified as inactive - #40915

tools: ping TSC members identified as inactive#40915nodejs-github-bot merged 3 commits intonodejs:masternodejs/node:masterfrom Trott:tsc-pingTrott/io.js:tsc-pingCopy head branch name to clipboard

Conversation

Trott commented Nov 21, 2021

Uh oh!

Trott commented Nov 21, 2021

Uh oh!

Uh oh!

targos commented Nov 22, 2021

Uh oh!

Trott commented Nov 24, 2021

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 24, 2021

Uh oh!

aduh95 commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

aduh95 commented Nov 25, 2021

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

Trott commented Nov 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tools: ping TSC members identified as inactive#40915
nodejs-github-bot merged 3 commits into
nodejs:masterfrom
Trott:tsc-ping

aduh95 commented Nov 25, 2021 •
edited
Loading