FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add note to net.isIP() about limitations by Trott · Pull Request #41028 · nodejs/node · GitHub

/ node Public

doc: add note to net.isIP() about limitations - #41028

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:isIP
Dec 2, 2021
ConversationCommits (1)ChecksFiles changed
Merged

doc: add note to net.isIP() about limitations#41028
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
Trott:isIP

Conversation

Trott commented Nov 30, 2021

Copy link
Copy Markdown
Member

Closes: #40966

Trott requested a review from mscdex November 30, 2021 02:47
nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Nov 30, 2021

mscdex commented Nov 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I would probably just be explicit about it and say the only accepted format for IPv4 addresses is the traditional/conventional quad-dotted decimal notation (which should imply base 10 numbers only for each octet).

jasnell commented Nov 30, 2021

Copy link
Copy Markdown
Member

I agree that it would be better to be more explicit. Also, some examples would be nice as not everyone will be immediately familiar with what "conventional IP format" means.

Trott commented Dec 2, 2021

Copy link
Copy Markdown
Member Author

@mscdex @jasnell Updated with more explicit explanation and code examples. PTAL.

mscdex commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

LGTM

MylesBorins approved these changes Dec 2, 2021
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2021
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2021
nodejs-github-bot merged commit 97b8eb6 into nodejs:master Dec 2, 2021

nodejs-github-bot commented Dec 2, 2021

Copy link
Copy Markdown
Collaborator

Landed in 97b8eb6

Trott deleted the isIP branch December 2, 2021 21:22
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
doc: expand entries for isIP(), isIPv4(), and isIPv6()
b353ded 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
doc: expand entries for isIP(), isIPv4(), and isIPv6()
aef4bde 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
doc: expand entries for isIP(), isIPv4(), and isIPv6()
6472311 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
doc: expand entries for isIP(), isIPv4(), and isIPv6()
084decd 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
mscdex Awaiting requested review from mscdex
+1 more reviewer
MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

net.isIP fails to detect different formats

6 participants

Back | FazBrowse Home | New Git URL