FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: simplify CHANGELOG.md by Trott · Pull Request #40475 · nodejs/node · GitHub

/ node Public

doc: simplify CHANGELOG.md - #40475

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:changelog-de-sup
Closed

doc: simplify CHANGELOG.md#40475
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:changelog-de-sup

Conversation

Trott commented Oct 16, 2021

Copy link
Copy Markdown
Member

Remove unnecessary <sup> usage and lint-disabling comment.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 16, 2021
Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 16, 2021

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note this will conflct with #40119, and should probably not land until the release is out.

Copy link
Copy Markdown
Member

Note this will conflct with #40119, and should probably not land until the release is out.

It will also cause a conflict when we merge the changelog changes for the yet-to-be-opened 16 LTS transition release.

Trott commented Oct 20, 2021

Copy link
Copy Markdown
Member Author

Note this will conflct with #40119, and should probably not land until the release is out.

Rebased and resolved that conflict.

I guess this should also wait for 16.x to switch to LTS before landing so that conflict can be resolved too? @richardlau

richardlau commented Oct 20, 2021
edited
Loading

Copy link
Copy Markdown
Member

I guess this should also wait for 16.x to switch to LTS before landing so that conflict can be resolved too? @richardlau

It would make things easier for me if this waited until after the 16 LTS transition🙂.

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott added the blocked PRs that are blocked by other issues or PRs. label Oct 20, 2021

Trott commented Oct 20, 2021

Copy link
Copy Markdown
Member Author

Added blocked label. Can be removed after 16.x transitions to LTS.

richardlau removed the blocked PRs that are blocked by other issues or PRs. label Oct 26, 2021
Remove unnecessary `<sup>` usage and lint-disabling comment.
Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2021

Copy link
Copy Markdown
Contributor

Landed in 687debb...9c405f2

github-actions Bot closed this Oct 26, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2021
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: #40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott deleted the changelog-de-sup branch October 26, 2021 23:37
richardlau added a commit to richardlau/node-core-utils that referenced this pull request Oct 27, 2021
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
richardlau added a commit to nodejs/node-core-utils that referenced this pull request Oct 28, 2021
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
targos pushed a commit that referenced this pull request Nov 6, 2021
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: #40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Nov 8, 2021
danielleadams pushed a commit that referenced this pull request Jan 29, 2022
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: #40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this pull request Nov 2, 2022
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this pull request Nov 10, 2022
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this pull request Jan 27, 2023
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this pull request Jan 27, 2023
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this pull request Sep 14, 2023
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL