fix: update detection of changelog links (take 2) - #575
Merged
richardlau merged 1 commit intoOct 26, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Underscores in the links to the changelogs are escaped for markdown links but not escaped for HTML links.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## main #575 +/- ##
=======================================
Coverage 82.57% 82.57%
=======================================
Files 35 35
Lines 1750 1750
=======================================
Hits 1445 1445
Misses 305 305 Continue to review full report at Codecov.
|
Sorry, something went wrong.
This comment has been minimized.
Trott
approved these changes
Oct 26, 2021
Copy link
Copy Markdown
Member
|
I'm contemplating seeing if remark-gfm can be changed so that it doesn't escape _ in these situations at all. It's unnecessary, I think. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Underscores in the links to the changelogs are escaped for markdown
links but not escaped for HTML links.
Refs: #573
Refs: nodejs/node#40617