src: use a higher limit in the NearHeapLimitCallback - #41041
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash.
joyeecheung
force-pushed
the
heap-limit
branch
from
d4ac494 to
89dac29
Compare
November 30, 2021 17:08
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Nov 30, 2021
tniessen
approved these changes
Nov 30, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
Dec 2, 2021
jasnell
approved these changes
Dec 2, 2021
36 tasks
joyeecheung
added a commit
that referenced
this pull request
Dec 3, 2021
V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash. PR-URL: #41041 Refs: #41013 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 4, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash. PR-URL: #41041 Refs: #41013 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash. PR-URL: #41041 Refs: #41013 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash. PR-URL: #41041 Refs: #41013 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
V8 requires the NearHeapLimitCallback to return a limit that's higher than the initial one or otherwise it will crash. PR-URL: #41041 Refs: #41013 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
max-lt
added a commit
to openworkers/openworkers-runtime-v8
that referenced
this pull request
Feb 28, 2026
…llback V8 requires the NearHeapLimitCallback to return a limit higher than current_heap_limit, otherwise it goes straight to FatalProcessOutOfMemory and crashes the entire process. The previous code returned the same value, which V8 interpreted as "no room given". Now always returns current_heap_limit + 2MB headroom so V8 can complete the pending allocation and return to JS where terminate_execution() takes effect. This matches Node.js's fix (nodejs/node#41041) and Supabase edge-runtime's low_memory_multiplier approach. Bump 0.13.9 → 0.13.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 requires the NearHeapLimitCallback to return a limit that's higher
than the initial one or otherwise it will crash.
Refs: #41013
cc @targos