FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: fix typos in lib code comments by kuriyosh · Pull Request #40792 · nodejs/node · GitHub

/ node Public

lib: fix typos in lib code comments - #40792

Merged
aduh95 merged 3 commits into
nodejs:masterfrom
kuriyosh:fix-typos
Nov 12, 2021
ConversationCommits (3)ChecksFiles changed
Merged

lib: fix typos in lib code comments#40792
aduh95 merged 3 commits into
nodejs:masterfrom
kuriyosh:fix-typos

Conversation

kuriyosh commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

This fixes three typos in lib dir code comment.

  • methdod → method in lib/_http_incoming.js
  • catcheable → catchable in lib/events.js
  • instancee → instance in lib/path.js

nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Nov 12, 2021
VoltrexKeyva reviewed Nov 12, 2021
View reviewed changes
Comment thread lib/_http_incoming.js Outdated

VoltrexKeyva commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

As per the review, welcome @kuriyosh! And thanks for the pull request.

Good catches there, did you find these typos by eyesight or by the help of a tool? If a tool; then which? It would be helpful for us to use these kinds of tools to find typos.

VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Nov 12, 2021

kuriyosh commented Nov 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@VoltrexMaster
Thank you for your quick review! The typo I added myself is fixed.

I used aspell which is a spell checker tool with a custom dictionary registered some words used in node.

Mesteery added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 12, 2021
Ayase-252 added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 12, 2021

github-actions Bot commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Ayase-252. Please 👍 to approve.

watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021

nodejs-github-bot commented Nov 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40848/

VoltrexKeyva commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

@watilde we shouldn't run full Jenkins CIs on changes that only apply on the documentation or comment changes as it does not affect the node binary builds, but one has already ran so; might need to remember that. 😄

aduh95 merged commit 69f487e into nodejs:master Nov 12, 2021

aduh95 commented Nov 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in 69f487e, thanks a lot for the contribution 🎉

This was referenced Nov 13, 2021
Open
Open
Open
This was referenced Nov 16, 2021
Open
Open
targos pushed a commit that referenced this pull request Nov 21, 2021
lib: fix typos in lib code comments
10a842d 
PR-URL: #40792
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
lib: fix typos in lib code comments
d2a1d01 
PR-URL: #40792
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
lib: fix typos in lib code comments
4cb1e7c 
PR-URL: #40792
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
watilde watilde approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
Ayase-252 Ayase-252 approved these changes
+1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. fast-track PRs that do not need to wait for 48 hours to land. http Issues or PRs related to the http subsystem. path Issues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL