FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: skip documentation generation if no ICU by Trott · Pull Request #41091 · nodejs/node · GitHub

/ node Public

build: skip documentation generation if no ICU - #41091

Merged
Trott merged 2 commits into
nodejs:masterfrom
Trott:no-icu-no-doc
Dec 7, 2021
ConversationCommits (2)ChecksFiles changed
Merged

build: skip documentation generation if no ICU#41091
Trott merged 2 commits into
nodejs:masterfrom
Trott:no-icu-no-doc

Conversation

Trott commented Dec 5, 2021

Copy link
Copy Markdown
Member

Closes: #41077

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Dec 5, 2021

Trott commented Dec 5, 2021

Copy link
Copy Markdown
Member Author

Alternative to #41086

Trott mentioned this pull request Dec 5, 2021
Closed

Trott commented Dec 5, 2021

Copy link
Copy Markdown
Member Author

l didn't replicate the changes that are in Makefile in vcbuild.bat because we do not build without Intl on Windows in CI, so I don't even know if doing that works. If someone wants to test locally, we can maybe try to maintain parity. However, I wouldn't be surprised if --without-intl is already broken on Windows.

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2021

nodejs-github-bot commented Dec 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41360/

richardlau approved these changes Dec 5, 2021
View reviewed changes
Comment thread Makefile Outdated
Trott mentioned this pull request Dec 5, 2021
Closed
Trott added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Dec 5, 2021

nodejs-github-bot commented Dec 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41362/

nodejs-github-bot commented Dec 5, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41363/

github-actions Bot mentioned this pull request Dec 6, 2021
Open
21 tasks

nodejs-github-bot commented Dec 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41364/

nodejs-github-bot commented Dec 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41372/

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 6, 2021

github-actions Bot commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Dec 6, 2021
github-actions Bot mentioned this pull request Dec 7, 2021
Open
46 tasks
Trott removed the fast-track PRs that do not need to wait for 48 hours to land. label Dec 7, 2021
Trott added 2 commits December 7, 2021 09:24
build: skip documentation generation if no ICU
ce66633 
Closes: nodejs#41077

PR-URL: nodejs#41091
Fixes: nodejs#41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
tools: update highlight.js to 11.3.1
32f7218 
PR-URL: nodejs#41091
Fixes: nodejs#41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Trott commented Dec 7, 2021

Copy link
Copy Markdown
Member Author

Landed in e0a5877...32f7218

Trott merged commit 32f7218 into nodejs:master Dec 7, 2021
Trott deleted the no-icu-no-doc branch December 7, 2021 17:25
This was referenced Dec 8, 2021
Open
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
build: skip documentation generation if no ICU
831face 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
tools: update highlight.js to 11.3.1
7b606cf 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
build: skip documentation generation if no ICU
0e692e2 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
tools: update highlight.js to 11.3.1
1721048 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
build: skip documentation generation if no ICU
519d64c 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
tools: update highlight.js to 11.3.1
71d7928 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
build: skip documentation generation if no ICU
860d552 
Closes: #41077

PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
tools: update highlight.js to 11.3.1
1ff1521 
PR-URL: #41091
Fixes: #41077
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams mentioned this pull request Feb 1, 2022
Merged
richardlau mentioned this pull request Oct 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
richardlau richardlau approved these changes
aduh95 aduh95 approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

doc build problem in withoutintl builds

6 participants

Back | FazBrowse Home | New Git URL