build: use build-ci for benchmark merge-commit rebuild · nodejs/node@fda8ee8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fda8ee8

Browse filesBrowse the repository at this point in the historyBrowse files

anonrig

authored and

aduh95

committed

build: use build-ci for benchmark merge-commit rebuild

The merge-commit job used `make -j4`, which skips configure. After node.gyp or generated sources change, that can leave the comparison binary unlinked against new files. `make build-ci` re-runs configure first, matching the base-build step. Assisted-by: Grok Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #65362 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 parent 21655dc commit fda8ee8
Copy full SHA for fda8ee8

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • benchmark.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/benchmark.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/benchmark.yml

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -141,7 +141,7 @@ jobs:
141	141	--arg devTools '[]' \
142	142	--arg benchmarkTools '[]' \
143	143	--run '
144		- make -j4 V=1
	144	+ make build-ci -j4 V=1
145	145	'
146	146
147	147	- name: Run benchmark

0 commit comments

Comments

0 (0)